From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm@lists.01.org, Dave Jiang <dave.jiang@intel.com>,
Vishal L Verma <vishal.l.verma@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] nfit_test: improve structure offset handling
Date: Mon, 5 Mar 2018 11:42:19 -0700 [thread overview]
Message-ID: <20180305184219.GA30168@linux.intel.com> (raw)
In-Reply-To: <20180227172952.22177-1-ross.zwisler@linux.intel.com>
On Tue, Feb 27, 2018 at 10:29:50AM -0700, Ross Zwisler wrote:
> In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value
> which we use to calculate where in our 'nfit_buf' we will place our next
> structure. The handling of 'offset' and the calculation of the placement
> of the next structure is a bit inconsistent, though. We don't update
> 'offset' after we insert each structure, sometimes causing us to update it
> for multiple structures' sizes at once. When calculating the position of
> the next structure we aren't always able to just use 'offset', but
> sometimes have to add in other structure sizes as well.
>
> Fix this by updating 'offset' after each structure insertion in a
> consistent way, allowing us to always calculate the position of the next
> structure to be inserted by just using 'nfit_buf + offset'.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Ping on this series.
next prev parent reply other threads:[~2018-03-05 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 17:29 [PATCH 1/3] nfit_test: improve structure offset handling Ross Zwisler
2018-02-27 17:29 ` [PATCH 2/3] nfit_test: fix buffer overrun, add sanity check Ross Zwisler
2018-02-27 17:29 ` [PATCH 3/3] nfit_test: prevent parsing error of nfit_test.0 Ross Zwisler
2018-03-05 18:42 ` Ross Zwisler [this message]
2018-03-06 19:13 ` [PATCH 1/3] nfit_test: improve structure offset handling Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305184219.GA30168@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox