From: Bin Liu <b-liu@ti.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Merlijn Wajer <merlijn@wizzup.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
<linux-omap@vger.kernel.org>
Subject: Re: usb: musb: "(null)" in sysfs mode file after disabling a gadget (and at other times, system hangs)
Date: Mon, 5 Mar 2018 13:28:44 -0600 [thread overview]
Message-ID: <20180305192844.GE14921@uda0271908> (raw)
In-Reply-To: <20180302165439.62xw4slhhupy4vy5@pali>
Merlijn,
On Fri, Mar 02, 2018 at 05:54:39PM +0100, Pali Rohár wrote:
> On Friday 02 March 2018 17:47:52 Merlijn Wajer wrote:
> > >> I would expect it to state "b_idle" instead of "(null)".
> > >
> > > Actually, I'd like to see (null) whenever a gadget driver is not loaded,
> > > which indicates a gadget is not bound to the udc.
> >
> > Hm... Sounds fine to me. I'm using this mode in combination with the usb
> > phy (vbus property) to detect if the phone is detect to a 'dumb' charger
> > of a PC, but I can just always have a gadget loaded -- same as before,
> > really.
>
> For detection if wallcharger or pc usb charger is connected, there is
> isp1704_charger driver. It uses some standard ULPI interface. It reports
> current_max and type (DCP - dedicated, CDP or just usb).
The musb udc driver sets the state to b_idle without checking a
gadget driver, this should be cleaned up. I have add this in my backlog.
But if this issue doesn't bother you much right now, I will make the
action low priority and address it later whenever I got time. (likely
not very soon, I have a hand full of musb driver bugs to fix...)
Regards,
-Bin.
next prev parent reply other threads:[~2018-03-05 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 23:47 usb: musb: "(null)" in sysfs mode file after disabling a gadget (and at other times, system hangs) Merlijn Wajer
2018-03-02 15:27 ` Bin Liu
2018-03-02 16:47 ` Merlijn Wajer
2018-03-02 16:54 ` Pali Rohár
2018-03-05 19:28 ` Bin Liu [this message]
2018-03-05 19:44 ` Merlijn Wajer
2018-03-06 14:36 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305192844.GE14921@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox