From: Guenter Roeck <linux@roeck-us.net>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Move declaration of of_irq_parse_and_map_pci under OF_IRQ
Date: Mon, 5 Mar 2018 15:19:36 -0800 [thread overview]
Message-ID: <20180305231936.GA14751@roeck-us.net> (raw)
In-Reply-To: <20180305215737.oxelfzdgsro6poee@rob-hp-laptop>
On Mon, Mar 05, 2018 at 03:57:37PM -0600, Rob Herring wrote:
> On Mon, Feb 26, 2018 at 03:19:05PM -0800, Guenter Roeck wrote:
> > Since commit 4670d610d5923 ("PCI: Move OF-related PCI functions into
> > PCI core"), sparc:allmodconfig fails to build with the following error.
> >
> > pcie-cadence-host.c:(.text+0x4c4):
> > undefined reference to `of_irq_parse_and_map_pci'
> > pcie-cadence-host.c:(.text+0x4c8):
> > undefined reference to `of_irq_parse_and_map_pci'
> >
> > of_irq_parse_and_map_pci is now only available if OF_IRQ is enabled.
> > Make its declaration and its dummy function dependent on OF_IRQ
> > to solve the problem.
> >
> > Fixes: 4670d610d5923 ("PCI: Move OF-related PCI functions into PCI core")
> > Cc: Rob Herring <robh@kernel.org>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > include/linux/of_pci.h | 17 ++++++++++-------
> > 1 file changed, 10 insertions(+), 7 deletions(-)
>
> Bjorn should take this. Can you resend to linux-pci so it is in his
> queue.
>
MAINTAINERS lists you as maintainer and devicetree@vger.kernel.org as
mailing list. But, sure, no problem.
Guenter
next prev parent reply other threads:[~2018-03-05 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 23:19 [PATCH] PCI: Move declaration of of_irq_parse_and_map_pci under OF_IRQ Guenter Roeck
2018-03-05 21:57 ` Rob Herring
2018-03-05 23:19 ` Guenter Roeck [this message]
2018-03-05 23:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305231936.GA14751@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox