* [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS
@ 2018-03-01 20:19 Shuah Khan
2018-03-06 0:18 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2018-03-01 20:19 UTC (permalink / raw)
To: shuah, dvhart, tbird20d
Cc: Shuah Khan, tglx, mingo, peterz, linux-kernel, linux-kselftest
Add top level TAP header echo, testname and separator line to make
the output consistent with the common run_tests target.
This change prevents nested TAP13 headers output from individual tests.
Nested TAP13 headers could cause problems for some parsers.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
Changes since v1:
- Add export KSFT_TAP_LEVEL to fix nested TAP header problem
for "make -C" usecase
- Update commit log with details on nested TAP headers.
tools/testing/selftests/futex/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index cea4adcd42b8..3006febb59fe 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -18,6 +18,10 @@ all:
done
override define RUN_TESTS
+ @export KSFT_TAP_LEVEL=`echo 1`;
+ @echo "TAP version 13";
+ @echo "selftests: futex";
+ @echo "========================================";
@cd $(OUTPUT); ./run.sh
endef
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS
2018-03-01 20:19 [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS Shuah Khan
@ 2018-03-06 0:18 ` Darren Hart
2018-03-07 2:37 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Darren Hart @ 2018-03-06 0:18 UTC (permalink / raw)
To: Shuah Khan
Cc: shuah, tbird20d, tglx, mingo, peterz, linux-kernel,
linux-kselftest
On Thu, Mar 01, 2018 at 01:19:07PM -0700, Shuah Khan wrote:
> Add top level TAP header echo, testname and separator line to make
> the output consistent with the common run_tests target.
>
> This change prevents nested TAP13 headers output from individual tests.
> Nested TAP13 headers could cause problems for some parsers.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS
2018-03-06 0:18 ` Darren Hart
@ 2018-03-07 2:37 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2018-03-07 2:37 UTC (permalink / raw)
To: Darren Hart
Cc: shuah, tbird20d, tglx, mingo, peterz, linux-kernel,
linux-kselftest, shuah Khan
On 03/05/2018 05:18 PM, Darren Hart wrote:
> On Thu, Mar 01, 2018 at 01:19:07PM -0700, Shuah Khan wrote:
>> Add top level TAP header echo, testname and separator line to make
>> the output consistent with the common run_tests target.
>>
>> This change prevents nested TAP13 headers output from individual tests.
>> Nested TAP13 headers could cause problems for some parsers.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>
>
> Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
>
>
Thanks. Queued this up with the rest for 4.17-rc1
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-07 2:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 20:19 [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS Shuah Khan
2018-03-06 0:18 ` Darren Hart
2018-03-07 2:37 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox