From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NV-DIMM Mailing List <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg
Date: Mon, 5 Mar 2018 21:06:30 -0700 [thread overview]
Message-ID: <20180306040630.GA9905@linux.intel.com> (raw)
In-Reply-To: <20180302122049.13900-1-jthumshirn@suse.de>
On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote:
> Dynamic debug can be instructed to add the function name to the debug
> output using the +f switch, so there is no need for the nfit module to
> do it again. If a user decides to add the +f switch for nfit's dynamic
> debug this results in double prints of the function name like the
> following:
>
> [ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10: func: 1 input length: 0
>
> Thus remove the stray __func__ printing.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Oh, Johannes I noticed that here is one stray one still in
drivers/acpi/nfit/mce.c. Do you mind pulling it into your patch to keep the
drivers/acpi/nfit/* changes together?
next prev parent reply other threads:[~2018-03-06 4:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 12:20 [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg Johannes Thumshirn
2018-03-05 17:49 ` Ross Zwisler
2018-03-05 17:53 ` Dan Williams
2018-03-05 18:01 ` Ross Zwisler
2018-03-05 18:12 ` Dan Williams
2018-03-06 0:55 ` Ross Zwisler
2018-03-06 4:06 ` Ross Zwisler [this message]
2018-03-06 16:52 ` Dan Williams
2018-03-08 8:03 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306040630.GA9905@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox