From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753077AbeCFEGd (ORCPT ); Mon, 5 Mar 2018 23:06:33 -0500 Received: from mga03.intel.com ([134.134.136.65]:44675 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbeCFEGb (ORCPT ); Mon, 5 Mar 2018 23:06:31 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,430,1515484800"; d="scan'208";a="32691960" Date: Mon, 5 Mar 2018 21:06:30 -0700 From: Ross Zwisler To: Johannes Thumshirn Cc: Dan Williams , Linux Kernel Mailinglist , Linux NV-DIMM Mailing List Subject: Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg Message-ID: <20180306040630.GA9905@linux.intel.com> References: <20180302122049.13900-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180302122049.13900-1-jthumshirn@suse.de> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this results in double prints of the function name like the > following: > > [ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10: func: 1 input length: 0 > > Thus remove the stray __func__ printing. > > Signed-off-by: Johannes Thumshirn Oh, Johannes I noticed that here is one stray one still in drivers/acpi/nfit/mce.c. Do you mind pulling it into your patch to keep the drivers/acpi/nfit/* changes together?