Re: [PATCH AUTOSEL for 4.9 005/219] kretprobes: Ensure probe location is at function entry

Naveen N. Rao
2018-03-05T07:03:09Z

Hi Sasha,

Sasha Levin wrote:
> From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
>
> [ Upstream commit 90ec5e89e393c76e19afc845d8f88a5dc8315919 ]
>

Sorry if this is obvious, but why was this patch picked up for -stable?
I don't see the upstream commit tagging -stable, so curious why this was
done.

I don't think this patch should be pushed to -stable since this is not
really a bug fix. There are also other dependencies for this change (see
commit a64e3f35a45f4a, for instance), including how userspace (perf)
builds out the retprobe argument. As such, please drop this from -stable
(for 3.18. 4.4 and 4.9).

Thanks,
Naveen