From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753752AbeCFQCK (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Mar 2018 11:02:10 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:48881 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753071AbeCFQCI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Mar 2018 11:02:08 -0500
Date: Tue, 6 Mar 2018 17:02:01 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings
Message-ID: <20180306160201.GE30557@lunn.ch>
References: <201803062304.hS8xIhIb%fengguang.wu@intel.com>
 <20180306155407.GA67333@lkp-g5>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180306155407.GA67333@lkp-g5>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 06, 2018 at 11:54:07PM +0800, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
> CC: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew