From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934175AbeCGPyH (ORCPT ); Wed, 7 Mar 2018 10:54:07 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46849 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934037AbeCGPx5 (ORCPT ); Wed, 7 Mar 2018 10:53:57 -0500 X-Google-Smtp-Source: AG47ELuTu9nVkCbsGzmCTr2LxmGErjPfLsXyk9gYwr80weNg3cpSruxSyirV9sQGEG6NLqyFi2KZEw== Date: Wed, 7 Mar 2018 15:53:53 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: groeck@chromium.org, andy.shevchenko@gmail.com, kernel@collabora.com, gwendal@chromium.org, linux-kernel@vger.kernel.org, Douglas Anderson , Benson Leung , Olof Johansson Subject: Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended Message-ID: <20180307155353.rtpvuxnbu2oxioz2@dell> References: <20180226102606.15093-1-enric.balletbo@collabora.com> <20180226102606.15093-4-enric.balletbo@collabora.com> <20180307155317.nnqfbnrf2w6wlgk4@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180307155317.nnqfbnrf2w6wlgk4@dell> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Mar 2018, Lee Jones wrote: > On Mon, 26 Feb 2018, Enric Balletbo i Serra wrote: > > > From: Douglas Anderson > > > > We should stop our worker thread while we're suspended. If we don't > > then we'll get messages like: > > > > cros-ec-spi spi5.0: spi transfer failed: -108 > > cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 > > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > > > Signed-off-by: Douglas Anderson > > Signed-off-by: Enric Balletbo i Serra > > Reviewed-by: Andy Shevchenko > > --- > > > > Changes in v3: > > - [3/8] Add Reviewed-by Andy Shevchenko. > > > > Changes in v2: > > - [3/8] That patch is new in this series. > > > > drivers/mfd/cros_ec_dev.c | 4 ++++ > > drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++ > > include/linux/mfd/cros_ec.h | 2 ++ > > 3 files changed, 26 insertions(+) > > I plan to make this patch 1/X and send it out as a pull-request. > > Acked-by: Lee Jones In fact better still, could you do that and add a note below the --- to that affect please? -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog