From: Andi Kleen <ak@linux.intel.com>
To: Ilya Pronin <ipronin@twitter.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf stat: fix cvs output format
Date: Wed, 7 Mar 2018 09:04:11 -0800 [thread overview]
Message-ID: <20180307170411.GI25017@tassilo.jf.intel.com> (raw)
In-Reply-To: <CA+Xn3kw2FZ4m1TossMT35KKJ7EsSV=ykdWKCHtjRs1oefdXWNw@mail.gmail.com>
On Tue, Mar 06, 2018 at 12:31:03PM -0800, Ilya Pronin wrote:
> Speaking from the user's seat. An optional (not just empty) cgroup
> field is fine as long it consistently appears when requested with -G
> option. The problem with print_metric_csv() was that in the case of
> unsupported counters 2 additional empty fields in the output are
> completely unexpected and not documented anywhere.
>
> Andi, in the output example in your commit
> 92a61f6412d3a09d6462252a522fa79c9290f405 stalled-cycles-backend event
> has counter run time field, counter run time percentage field, empty
> metric value, empty metric unit, and then 2 other empty fields. Are
> they expected? If yes, what are they and why other events, e.g.
No two extra empty fields are not expected. All lines should
have the same number of fields so that a tool that looks
at the first like can keep using the same number.
But I don't think that was it what the patch fixed, or did I
misread it?
-Andi
next prev parent reply other threads:[~2018-03-07 17:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 6:43 [PATCH] perf stat: fix cvs output format Cong Wang
2018-03-06 7:58 ` Jiri Olsa
2018-03-06 13:54 ` Arnaldo Carvalho de Melo
2018-03-06 17:00 ` Andi Kleen
2018-03-06 17:30 ` Arnaldo Carvalho de Melo
2018-03-06 18:57 ` Andi Kleen
2018-03-06 17:47 ` Cong Wang
2018-03-06 17:53 ` Andi Kleen
2018-03-06 19:03 ` Cong Wang
2018-03-06 20:31 ` Ilya Pronin
2018-03-07 17:04 ` Andi Kleen [this message]
2018-03-08 21:52 ` Ilya Pronin
2018-03-09 0:06 ` Andi Kleen
2018-03-07 8:27 ` [tip:perf/urgent] perf stat: Fix CVS output format for non-supported counters tip-bot for Ilya Pronin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307170411.GI25017@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=ipronin@twitter.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox