From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754681AbeCGTFs (ORCPT ); Wed, 7 Mar 2018 14:05:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:41136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754333AbeCGTFq (ORCPT ); Wed, 7 Mar 2018 14:05:46 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE4B72172D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 7 Mar 2018 16:05:43 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Agustin Vega-Frias , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , timur@codeaurora.org Subject: Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events Message-ID: <20180307190543.GR3701@kernel.org> References: <1520345084-42646-1-git-send-email-agustinv@codeaurora.org> <1520345084-42646-2-git-send-email-agustinv@codeaurora.org> <20180307160224.GN3701@kernel.org> <20180307185415.GK25017@tassilo.jf.intel.com> <20180307190509.GQ3701@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307190509.GQ3701@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > > > not POSIX, and the Alpine and Android runtimes likely don't implement > > > that... > > > I'll send a fix reverting back to the strncmp to ignore the uncore_ prefix, > > > and dropping that extension. > > > > Just don't set it? Even the basic glob patterns are useful. > > Or use: > > #ifndef FNM_EXTMATCH > #define FNM_EXTMATCH 0 > #endif > > So on systems without it, its not used, while on GNU systems, we have > that functionality (pretty fancy, someone may need that... ;-)) I'll try this route, btw, no need to send more patches for now. - Arnaldo