From: Jonathan Cameron <jic23@kernel.org>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com,
lars@metafoo.de, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de
Subject: Re: [PATCH v3 3/4] Staging: iio: adis16209: Adjust a switch statement
Date: Wed, 7 Mar 2018 21:07:28 +0000 [thread overview]
Message-ID: <20180307210728.59457080@archlinux> (raw)
In-Reply-To: <5c523865f71eb68181bd2b207685bdf5e9b8da83.1520164945.git.shreeya.patel23498@gmail.com>
On Sun, 4 Mar 2018 18:13:12 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> Adjust a switch block to explicitly match channels and
> return -EINVAL as default case which makes the code
> semantically more clear.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan.
> ---
>
> Changes in v3
> -After split patch.
>
> drivers/staging/iio/accel/adis16209.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index eb5c878..9cb1ce0 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -155,10 +155,16 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
> switch (chan->type) {
> case IIO_VOLTAGE:
> *val = 0;
> - if (chan->channel == 0)
> + switch (chan->channel) {
> + case 0:
> *val2 = 305180; /* 0.30518 mV */
> - else
> + break;
> + case 1:
> *val2 = 610500; /* 0.6105 mV */
> + break;
> + default:
> + return -EINVAL;
> + }
> return IIO_VAL_INT_PLUS_MICRO;
> case IIO_TEMP:
> *val = -470;
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-07 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 12:34 [PATCH v3 0/4] adis16209 driver cleanup Shreeya Patel
2018-03-04 12:36 ` [PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions Shreeya Patel
2018-03-04 12:56 ` Himanshu Jha
2018-03-04 13:07 ` Shreeya Patel
2018-03-07 21:02 ` Jonathan Cameron
2018-03-04 12:41 ` [PATCH v3 2/4] Staging: iio: adis16209: Change some macro names Shreeya Patel
2018-03-07 21:06 ` Jonathan Cameron
2018-03-04 12:43 ` [PATCH v3 3/4] Staging: iio: adis16209: Adjust a switch statement Shreeya Patel
2018-03-07 21:07 ` Jonathan Cameron [this message]
2018-03-04 12:45 ` [PATCH v3 4/4] Staging: iio: adis16209: Use sign_extend32 function Shreeya Patel
2018-03-07 21:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307210728.59457080@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox