From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: a.zummo@towertech.it, arnd@arndb.de, broonie@kernel.org,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 1/3] rtc: Use time64_t to save range_max of RTC
Date: Wed, 7 Mar 2018 23:54:11 +0100 [thread overview]
Message-ID: <20180307225411.GA20370@piout.net> (raw)
In-Reply-To: <b8a475beaa4739032e3346572af2e412ebccb787.1519633350.git.baolin.wang@linaro.org>
Hi,
On 26/02/2018 at 16:33:56 +0800, Baolin Wang wrote:
> We need use rtc->range_max to valid if the time values are valid,
> and the time values are saved by time64_t type. So change the
> rtc->range_max to time64_t type for comparison correctly.
>
I'm not applying this one because the described issue will never happen
as negative times are forbidden by the rtc subsystem.
I've applied the two following patches
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> include/linux/rtc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/rtc.h b/include/linux/rtc.h
> index bdfc0c4..8560282 100644
> --- a/include/linux/rtc.h
> +++ b/include/linux/rtc.h
> @@ -152,7 +152,7 @@ struct rtc_device {
> struct bin_attribute *nvram;
>
> time64_t range_min;
> - timeu64_t range_max;
> + time64_t range_max;
>
> #ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL
> struct work_struct uie_task;
> --
> 1.7.9.5
>
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-07 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:33 [RESEND PATCH 1/3] rtc: Use time64_t to save range_max of RTC Baolin Wang
2018-02-26 8:33 ` [RESEND PATCH 2/3] rtc: Factor out the RTC range validation into rtc_valid_range() Baolin Wang
2018-02-26 8:33 ` [RESEND PATCH 3/3] rtc: Add one offset seconds to expand RTC range Baolin Wang
2018-03-07 22:54 ` Alexandre Belloni [this message]
2018-03-08 2:47 ` [RESEND PATCH 1/3] rtc: Use time64_t to save range_max of RTC Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307225411.GA20370@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox