From: Tom Bogendoerfer <tsbogend@alpha.franken.de>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls
Date: Fri, 9 Mar 2018 11:52:49 +0100 [thread overview]
Message-ID: <20180309105249.GA6536@alpha.franken.de> (raw)
In-Reply-To: <S1751161AbeCGG4v/20180307065653Z+38@vger.kernel.org>
On Wed, Mar 07, 2018 at 05:56:41PM +1100, Finn Thain wrote:
> In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev
> in dma api calls as if it was a pointer to a struct device. But
> it actually points to a struct platform_device. Fix this.
>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Looks good.
Reviewed-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2018-03-09 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 6:56 [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls Finn Thain
2018-03-09 10:52 ` Tom Bogendoerfer [this message]
[not found] <S1751076AbeCGG4t/20180307065702Z+42@vger.kernel.org>
2018-03-13 2:06 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309105249.GA6536@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=fthain@telegraphics.com.au \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox