From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932979AbeCJErh (ORCPT ); Fri, 9 Mar 2018 23:47:37 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:48226 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932343AbeCJErf (ORCPT ); Fri, 9 Mar 2018 23:47:35 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 64DFD602A0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Fri, 9 Mar 2018 21:47:32 -0700 From: Lina Iyer To: Steven Rostedt Cc: andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, rnayak@codeaurora.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, sboyd@kernel.org Subject: Re: [PATCH v4 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE Message-ID: <20180310044732.GB2806@codeaurora.org> References: <20180309232543.24636-1-ilina@codeaurora.org> <20180309232543.24636-4-ilina@codeaurora.org> <20180309185223.19aa6c84@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180309185223.19aa6c84@gandalf.local.home> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 09 2018 at 16:52 -0700, Steven Rostedt wrote: >On Fri, 9 Mar 2018 16:25:36 -0700 >Lina Iyer wrote: > >> Log sent RPMH requests and interrupt responses in FTRACE. >> >> Cc: Steven Rostedt >> Signed-off-by: Lina Iyer >> --- >> >> Changes in v4: >> - fix compilation issues, use __assign_str >> - use %#x instead of 0x%08x > >Hmm, I don't believe libtraceevent (used by trace-cmd and perf) >supports "%#x". But that needs to be fixed in libtraceevent and you >don't need to modify this patch. > >+ __field(bool, wait) > >Usually I would recommend against 'bool' in structures, but it >shouldn't affect the tracing code. Might want to look at how it >converts it in the /sys/kernel/tracing/events/rpmh/rpmh_send_msg/format >file. It probably makes no difference if it was an int. > >Other than that... Looks good. field:bool wait; offset:32; size:1; signed:0; -- Lina > >Reviewed-by: Steven Rostedt (VMware) > >-- Steve > > >> Changes in v3: >> - Use __string() instead of char * >> - fix TRACE_INCLUDE_PATH >> ---