From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELs5PeIU8e0gWa+ynDHwDVl7qFtNvdjc/zoIclU94i6nr/9UNgMx4ysLevYM6CQkZQ/Gu/BK ARC-Seal: i=1; a=rsa-sha256; t=1520691330; cv=none; d=google.com; s=arc-20160816; b=mlg1cjYHF68IZPlqIWAH2HC5oy/uysGVMaESLNKH77Oj/Sn9JGXMd9d1C/zoXlfBts 5lyox7ArRqOJ7k4MqqI/kClNkCeMd1ezOqEQZ7d+VIx/14TvOnud5Aeoo3iWSmZfftl2 qDuxSXPsd8zfoo64g2Cp2i3ovAd4j5Og1r/MQajPxU+M8i/W40KHXDdAjdsYtaUSZVCg +JIhplzFMDXzSDyjp1p3ZxHbdRso0IvPp1zxdrwk6VPjb5dcSWETnc7RrAy5bQiqMc7z w+ckkh0eGdKcX/YiGpyRg/nEw6CcyD0rffOxCbKebQJIkd9/HVa2zQRjfrgiRrYczUAx ygXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dmarc-filter:arc-authentication-results; bh=maVKqsQDiM/HH9N4onBGOhnqkoujZpEBf8uMTZT28m4=; b=RzWdDFDm54V7bmXpr7E/IBIfNrLblTGMQbvahKjDlJvMH60FOT38s7PQKtxssYkLdm 5ZseS/5iFipadzVBBHrLu694zUGO9VRKsrLeI0Uul++WnqEd27fdAWzd8LFkEWsPW0O2 V2Lac3S4hvuDnpV47yQ1zEEcQHc7ugd9dlUs0VZyeOSS9hSubGwova4kirGK8DhWymLl bcT6QMTpPX3/qGelw1UnQ+udwQyVaQwMc4AzItMI/ponqbpnBxXNWcKQHm0NyaL+Nk7R 005KuCufGNgVxqAzrhjExVQKLkhHIXni3ohxVjZBnNWyf4oGxLSnztop7psVuYk4StrP 2chA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of mcgrof@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=mcgrof@kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of mcgrof@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=mcgrof@kernel.org DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67F27217CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mcgrof@kernel.org From: "Luis R. Rodriguez" To: gregkh@linuxfoundation.org Cc: akpm@linux-foundation.org, cantabile.desu@gmail.com, kubakici@wp.pl, linux-wireless@vger.kernel.org, keescook@chromium.org, shuah@kernel.org, mfuzzey@parkeon.com, zohar@linux.vnet.ibm.com, dhowells@redhat.com, pali.rohar@gmail.com, tiwai@suse.de, arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com, markivx@codeaurora.org, broonie@kernel.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, torvalds@linux-foundation.org, Abhay_Salunke@dell.com, bjorn.andersson@linaro.org, jewalt@lgsinnovations.com, oneukum@suse.com, ast@fb.com, andresx7@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Luis R. Rodriguez" Subject: [PATCH v3 14/20] rename: _request_firmware_load() fw_load_sysfs_fallback() Date: Sat, 10 Mar 2018 06:14:55 -0800 Message-Id: <20180310141501.2214-15-mcgrof@kernel.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20180310141501.2214-1-mcgrof@kernel.org> References: <20180310141501.2214-1-mcgrof@kernel.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1594560432724549744?= X-GMAIL-MSGID: =?utf-8?q?1594560432724549744?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: This reflects much clearer what is being done. While at it, kdoc'ify it. Signed-off-by: Luis R. Rodriguez --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 2 +- drivers/base/firmware_loader/fallback.c | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/Documentation/driver-api/firmware/fallback-mechanisms.rst b/Documentation/driver-api/firmware/fallback-mechanisms.rst index 4055ac76b288..f353783ae0be 100644 --- a/Documentation/driver-api/firmware/fallback-mechanisms.rst +++ b/Documentation/driver-api/firmware/fallback-mechanisms.rst @@ -112,7 +112,7 @@ Since a device is created for the sysfs interface to help load firmware as a fallback mechanism userspace can be informed of the addition of the device by relying on kobject uevents. The addition of the device into the device hierarchy means the fallback mechanism for firmware loading has been initiated. -For details of implementation refer to _request_firmware_load(), in particular +For details of implementation refer to fw_load_sysfs_fallback(), in particular on the use of dev_set_uevent_suppress() and kobject_uevent(). The kernel's kobject uevent mechanism is implemented in lib/kobject_uevent.c, diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index d6838e7ec00c..0a8ec7fec585 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -535,8 +535,15 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, return fw_sysfs; } -/* load a firmware via user helper */ -static int _request_firmware_load(struct fw_sysfs *fw_sysfs, +/** + * fw_load_sysfs_fallback - load a firmware via the syfs fallback mechanism + * @fw_sysfs: firmware syfs information for the firmware to load + * @opt_flags: flags of options, FW_OPT_* + * @timeout: timeout to wait for the load + * + * In charge of constructing a sysfs fallback interface for firmware loading. + **/ +static int fw_load_sysfs_fallback(struct fw_sysfs *fw_sysfs, unsigned int opt_flags, long timeout) { int retval = 0; @@ -621,7 +628,7 @@ static int fw_load_from_user_helper(struct firmware *firmware, } fw_sysfs->fw_priv = firmware->priv; - ret = _request_firmware_load(fw_sysfs, opt_flags, timeout); + ret = fw_load_sysfs_fallback(fw_sysfs, opt_flags, timeout); if (!ret) ret = assign_fw(firmware, device, opt_flags); -- 2.16.2