From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Vas Dias <jason.vas.dias@gmail.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
andi <andi@firstfloor.org>, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW
Date: Mon, 12 Mar 2018 08:24:13 +0100 [thread overview]
Message-ID: <20180312072413.toyd5ztkgaah35xg@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1803112350190.1485@nanos.tec.linutronix.de>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 12 Mar 2018, Jason Vas Dias wrote:
>
> checkpatch.pl still reports:
>
> total: 15 errors, 3 warnings, 165 lines checked
>
> > +notrace static u64 vread_tsc_raw(void)
> > +{
> > + u64 tsc, last=gtod->raw_cycle_last;
> > + if( likely( gtod->has_rdtscp ) )
> > + tsc = rdtscp((void*)0);
>
> Plus I asked more than once to split that rdtscp() stuff into a separate
> patch.
>
> You surely are free to ignore my review comments, but rest assured that I'm
> free to ignore the crap you insist to send me as well.
In addition to Thomas's review feedback I'd strongly urge the careful reading of
Documentation/SubmittingPatches as well:
- When sending multiple patches please use git-send-mail
- Please don't send several patch iterations per day!
- Code quality of the submitted patches is atrocious, please run them through
scripts/checkpatch.pl (and make sure they pass) to at least enable the reading
of them.
- ... plus dozens of other details described in Documentation/SubmittingPatches.
Thanks,
Ingo
next prev parent reply other threads:[~2018-03-12 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 5:01 [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW Jason Vas Dias
2018-03-12 6:53 ` Thomas Gleixner
2018-03-12 7:24 ` Ingo Molnar [this message]
2018-03-12 8:10 ` Peter Zijlstra
2018-03-12 8:24 ` Ingo Molnar
[not found] ` <CALyZvKx0AfVvhD3gs7mWMA_PE08JHoFSzk4rJWSozsCU9YLWmg@mail.gmail.com>
2018-03-12 8:30 ` Jason Vas Dias
2018-03-12 9:17 ` Jason Vas Dias
-- strict thread matches above, loose matches on Subject: below --
2018-03-12 9:12 Jason Vas Dias
2018-03-12 9:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312072413.toyd5ztkgaah35xg@gmail.com \
--to=mingo@kernel.org \
--cc=andi@firstfloor.org \
--cc=jason.vas.dias@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox