public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jason Vas Dias <jason.vas.dias@gmail.com>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	andi <andi@firstfloor.org>
Subject: Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW
Date: Mon, 12 Mar 2018 09:24:29 +0100	[thread overview]
Message-ID: <20180312082429.yxyaennsgfzkoohh@gmail.com> (raw)
In-Reply-To: <20180312081007.GD4043@hirez.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Mar 12, 2018 at 08:24:13AM +0100, Ingo Molnar wrote:
> 
> >  - Code quality of the submitted patches is atrocious, please run them through
> >    scripts/checkpatch.pl (and make sure they pass) to at least enable the reading 
> >    of them.
> 
> I'd suggest also reading: Documentation/CodingStyle

Yeah, a careful reading of Documentation/process/submitting-patches.rst will 
include:

  4) Style-check your changes
  ---------------------------

  Check your patch for basic style violations, details of which can be
  found in
  :ref:`Documentation/process/coding-style.rst <codingstyle>`.
  Failure to do so simply wastes
  the reviewers time and will get your patch rejected, probably
  without even being read.


Thanks,

	Ingo

  reply	other threads:[~2018-03-12  8:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  5:01 [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW Jason Vas Dias
2018-03-12  6:53 ` Thomas Gleixner
2018-03-12  7:24   ` Ingo Molnar
2018-03-12  8:10     ` Peter Zijlstra
2018-03-12  8:24       ` Ingo Molnar [this message]
     [not found]     ` <CALyZvKx0AfVvhD3gs7mWMA_PE08JHoFSzk4rJWSozsCU9YLWmg@mail.gmail.com>
2018-03-12  8:30       ` Jason Vas Dias
2018-03-12  9:17         ` Jason Vas Dias
  -- strict thread matches above, loose matches on Subject: below --
2018-03-12  9:12 Jason Vas Dias
2018-03-12  9:28 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312082429.yxyaennsgfzkoohh@gmail.com \
    --to=mingo@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=jason.vas.dias@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox