From: "<Hariprasath Elango>" <hariprasath.elango@gmail.com>
To: hariprasath.elango@gmail.com
Cc: devel@driverdev.osuosl.org, vbabu3@visteon.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org,
Hari Prasath <hgujulan@visteon.com>,
linux-kernel@vger.kernel.org,
Ganesh Krishna <ganesh.krishna@microchip.com>,
aditya.shankar@microchip.com
Subject: Re: [PATCH] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
Date: Mon, 12 Mar 2018 15:08:08 +0530 [thread overview]
Message-ID: <20180312093808.GA9044@hariprasath> (raw)
In-Reply-To: <20180312084715.30103-1-hariprasath.elango@gmail.com>
On Mon, Mar 12, 2018 at 02:17:15PM +0530, hariprasath.elango@gmail.com wrote:
> From: Hari Prasath <hgujulan@visteon.com>
>
> Use the kernel pre-defined macro is_broadcast_ether_addr() instead of
> doing a memcmp here.
>
> Signed-off-by: Hari Prasath <hgujulan@visteon.com>
> ---
> drivers/staging/wilc1000/linux_mon.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
> index bbdfc7a..f93f411 100644
> --- a/drivers/staging/wilc1000/linux_mon.c
> +++ b/drivers/staging/wilc1000/linux_mon.c
> @@ -27,7 +27,6 @@ static struct net_device *wilc_wfi_mon; /* global monitor netdev */
>
> static u8 srcadd[6];
> static u8 bssid[6];
> -static u8 broadcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
> /**
> * @brief WILC_WFI_monitor_rx
> * @details
> @@ -193,7 +192,7 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
>
> skb_pull(skb, rtap_len);
>
> - if (skb->data[0] == 0xc0 && (!(memcmp(broadcast, &skb->data[4], 6)))) {
> + if (skb->data[0] == 0xc0 && is_broadcast_ether_addr(&skb->data[4])) {
> skb2 = dev_alloc_skb(skb->len + sizeof(struct wilc_wfi_radiotap_cb_hdr));
> if (!skb2)
> return -ENOMEM;
> --
> 2.10.0.GIT
>
Kindly discard this patch. I will send a v2 as sent mail ID and
signed-off are not matching
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-03-12 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 8:47 [PATCH] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr hariprasath.elango
2018-03-12 9:38 ` <Hariprasath Elango> [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312093808.GA9044@hariprasath \
--to=hariprasath.elango@gmail.com \
--cc=aditya.shankar@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=hgujulan@visteon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vbabu3@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox