public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster
Date: Mon, 12 Mar 2018 13:42:46 +0100	[thread overview]
Message-ID: <20180312124246.GC23111@krava> (raw)
In-Reply-To: <20180310023907.798690563@goodmis.org>

On Fri, Mar 09, 2018 at 09:34:45PM -0500, Steven Rostedt wrote:

SNIP

>  
> -/* If not of not match is equal to not of not, then it is a match */
> +/*
> + * Without going into a formal proof, this explains the method that is used in
> + * parsing the logical expressions.
> + *
> + * For example, if we have: "a && !(!b || (c && g)) || d || e && !f"
> + * The first pass will convert it into the following program:
> + *
> + * n1: r=a;       l1: if (!r) goto l4;
> + * n2: r=b;       l2: if (!r) goto l4;

got stuck in here.. should that be 'goto l5' ?

jirka

> + * n3: r=c; r=!r; l3: if (r) goto l4;
> + * n4: r=g; r=!r; l4: if (r) goto l5;
> + * n5: r=d;       l5: if (r) goto T
> + * n6: r=e;       l6: if (!r) goto l7;
> + * n7: r=f; r=!r; l7: if (!r) goto F
> + * T: return TRUE
> + * F: return FALSE

jirka

  parent reply	other threads:[~2018-03-12 12:42 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10  2:34 [PATCH 0/3] tracing: Rewrite the function filter code Steven Rostedt
2018-03-10  2:34 ` [PATCH 1/3] tracing: Combine enum and arrays into single macro in " Steven Rostedt
2018-03-12 10:31   ` Masami Hiramatsu
2018-03-10  2:34 ` [PATCH 2/3] tracing: Clean up and document pred_funcs_##type creation and use Steven Rostedt
2018-03-12 13:42   ` Masami Hiramatsu
2018-03-10  2:34 ` [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster Steven Rostedt
2018-03-10  3:10   ` Steven Rostedt
2018-03-10  3:15     ` Steven Rostedt
2018-03-10  3:22       ` Steven Rostedt
2018-03-10  3:18   ` Steven Rostedt
2018-03-12 12:42   ` Jiri Olsa [this message]
2018-03-12 18:38     ` Steven Rostedt
2018-03-12 15:10   ` Jiri Olsa
2018-03-12 18:40     ` Steven Rostedt
2018-03-12 18:54       ` Jiri Olsa
2018-03-12 19:10         ` Steven Rostedt
2018-03-12 23:52         ` Steven Rostedt
2018-03-13 10:14           ` Jiri Olsa
2018-03-13 14:12             ` Steven Rostedt
2018-03-13 14:27               ` Jiri Olsa
2018-03-11 19:54 ` [PATCH 0/3] tracing: Rewrite the function filter code Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2018-03-09 20:05 [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max() Kees Cook
2018-03-09 21:10 ` Linus Torvalds
2018-03-09 21:47   ` Kees Cook
2018-03-11 22:46   ` Tobin C. Harding
2018-03-13 13:31   ` David Laight
2018-03-10  0:07 ` Andrew Morton
2018-03-10  0:28   ` Linus Torvalds
2018-03-10  0:32     ` Andrew Morton
2018-03-10  0:38       ` Linus Torvalds
2018-03-10  1:30         ` Kees Cook
2018-03-10  1:31           ` Kees Cook
2018-03-10  2:37             ` Linus Torvalds
2018-03-12 22:55           ` Andrew Morton
2018-03-12 23:57             ` Linus Torvalds
2018-03-13  4:28               ` Kees Cook
2018-03-13 21:02                 ` Andrew Morton
2018-03-13 22:14                   ` Kees Cook
2018-03-14 11:35                     ` David Laight
2018-03-10  3:11   ` Randy Dunlap
2018-03-10  6:10     ` Miguel Ojeda
2018-03-10  7:03       ` Miguel Ojeda
2018-03-10 16:04         ` Linus Torvalds
2018-03-10 15:33       ` Kees Cook
2018-03-10 16:11         ` Linus Torvalds
2018-03-10 16:30         ` Linus Torvalds
2018-03-10 17:34           ` Miguel Ojeda
2018-03-10 17:51             ` Linus Torvalds
2018-03-10 19:08               ` Miguel Ojeda
2018-03-11 11:05               ` Ingo Molnar
2018-03-11 18:23                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312124246.GC23111@krava \
    --to=jolsa@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tom.zanussi@linux.intel.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox