From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Ognjen Galić" <smclt30p@gmail.com>,
"kernel list" <linux-kernel@vger.kernel.org>,
"ACPI mailing list" <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Sebastian Reichel" <sre@kernel.org>
Subject: Re: linux-next on thinkpad x60: full battery is indicated as battery error in mate
Date: Tue, 13 Mar 2018 00:18:47 +0100 [thread overview]
Message-ID: <20180312231847.GB7612@amd> (raw)
In-Reply-To: <CAJZ5v0irEfMxURr2c8VZ=SZhsW+MWxRd4OwDH5bS6P=R3a0REw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1684 bytes --]
Hi!
> >> > >> Fully charged
> >> > >> battery shows as empty battery with red "x" in Mate desktop. After
> >> > >> reboot to recent mainline problem goes away. Tooltip says "battery
> >> > >> waiting to charge".
> >> > >>
> >>
> >> For the MATE bug see:
> >> https://github.com/mate-desktop/mate-power-manager/pull/251
> >>
> >> The problem is in the new composite battery system in UPower, it
> >> "merges" two external batteries into a single one for reporting. That
> >> battery does not understand "Not Charging" inside the MATE Power
> >> Manager. The above patch fixes that in MATE.
> >
> > Ok, so problem is 91eea70e5e5ce12eb1c7cd922e561fab43e201bd.
> >
> > And now, I see that MATE should be improved.
> >
> > But what I also see is that kernel is changing its interface in a way
> > that (while making sense) breaks existing application. And we don't
> > break existing applications.
> >
> > [Now... maybe if the fix for the application is available for long
> > long time and noone is really looking and everyone already has new
> > application version, maybe ... But pull request for MATE is 9 days
> > old, and not even merged. So there is no way this is suitable for
> > 4.17.]
>
> Right.
>
> This basically means that we will have to defer the battery changes
> until user space is ready and not just upstream, but also in distro
> packages.
Yes please.
Note that only 91eea70e5e5ce12eb1c7cd922e561fab43e201bd should break
anything, the others should be safe AFAICT?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-12 23:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:47 linux-next on thinkpad x60: full battery is indicated as battery error in mate Pavel Machek
2018-03-12 19:49 ` Pavel Machek
2018-03-12 22:29 ` Rafael J. Wysocki
2018-03-12 22:35 ` Ognjen Galić
2018-03-12 23:04 ` Pavel Machek
2018-03-12 23:06 ` Rafael J. Wysocki
2018-03-12 23:18 ` Pavel Machek [this message]
2018-03-12 23:39 ` Ognjen Galić
2018-03-13 0:51 ` Ognjen Galić
2018-03-13 9:14 ` Rafael J. Wysocki
2018-03-13 9:15 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312231847.GB7612@amd \
--to=pavel@ucw.cz \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=smclt30p@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox