From: Ming Lei <ming.lei@redhat.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Dou Liyang <douly.fnst@cn.fujitsu.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Laurence Oberman <loberman@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH V3 0/4] genirq/affinity: irq vector spread among online CPUs as far as possible
Date: Tue, 13 Mar 2018 16:35:41 +0800 [thread overview]
Message-ID: <20180313083535.GA21612@ming.t460p> (raw)
In-Reply-To: <1520926721.20980.210.camel@gmail.com>
On Tue, Mar 13, 2018 at 09:38:41AM +0200, Artem Bityutskiy wrote:
> On Tue, 2018-03-13 at 11:11 +0800, Dou Liyang wrote:
> > I also
> > met the situation that BIOS told to ACPI that it could support
> > physical
> > CPUs hotplug, But actually, there was no hardware slots in the
> > machine.
> > the ACPI tables like user inputs which should be validated when we
> > use.
>
> This is exactly what happens on Skylake Xeon systems. When I check
> dmesg or this file:
>
> /sys/devices/system/cpu/possible
>
> on 2S (two socket) and 4S (four socket) systems, I see the same number
> 432.
>
> This number comes from ACPI MADT. I will speculate (did not see myself)
> that 8S systems will report the same number as well, because of the
> Skylake-SP (Scalable Platform) architecture.
>
> Number 432 is good for 8S systems, but it is way too large for 2S and
> 4S systems - 4x or 2x larger than the theoretical maximum.
>
> I do not know why BIOSes have to report unrealistically high numbers, I
> am just sharing my observation.
>
> So yes, Linux kernel's possible CPU count knowledge may be too large.
> If we use that number to evenly spread IRQ vectors among the CPUs, we
> end up with wasted vectors, and even bugs, as I observe on a 2S
> Skylake.
Then looks this issue need to fix by making possible CPU count accurate
because there are other resources allocated according to num_possible_cpus(),
such as percpu variables.
Thanks,
Ming
next prev parent reply other threads:[~2018-03-13 8:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 10:53 [PATCH V3 0/4] genirq/affinity: irq vector spread among online CPUs as far as possible Ming Lei
2018-03-08 10:53 ` [PATCH V3 1/4] genirq/affinity: rename *node_to_possible_cpumask as *node_to_cpumask Ming Lei
2018-04-06 21:52 ` [tip:irq/core] genirq/affinity: Rename " tip-bot for Ming Lei
2018-03-08 10:53 ` [PATCH V3 2/4] genirq/affinity: move actual irq vector spread into one helper Ming Lei
2018-04-06 21:53 ` [tip:irq/core] genirq/affinity: Move actual irq vector spreading into a helper function tip-bot for Ming Lei
2018-03-08 10:53 ` [PATCH V3 3/4] genirq/affinity: support to do irq vectors spread starting from any vector Ming Lei
2018-04-06 21:53 ` [tip:irq/core] genirq/affinity: Allow irq spreading from a given starting point tip-bot for Ming Lei
2018-03-08 10:53 ` [PATCH V3 4/4] genirq/affinity: irq vector spread among online CPUs as far as possible Ming Lei
2018-04-03 13:32 ` Thomas Gleixner
2018-04-03 16:00 ` Ming Lei
2018-04-04 8:25 ` Thomas Gleixner
2018-04-04 12:45 ` Thomas Gleixner
2018-04-04 15:20 ` Ming Lei
2018-04-05 10:12 ` Thomas Gleixner
2018-04-04 15:08 ` Ming Lei
2018-04-04 19:38 ` Thomas Gleixner
2018-04-06 9:13 ` Ming Lei
2018-04-06 9:46 ` Thomas Gleixner
2018-04-06 21:49 ` Thomas Gleixner
2018-04-08 3:19 ` Ming Lei
2018-04-06 21:54 ` [tip:irq/core] genirq/affinity: Spread irq vectors among present " tip-bot for Ming Lei
2018-03-08 13:18 ` [PATCH V3 0/4] genirq/affinity: irq vector spread among online " Artem Bityutskiy
2018-03-08 13:25 ` Artem Bityutskiy
2018-03-08 13:34 ` Ming Lei
2018-03-08 23:20 ` Thomas Gleixner
2018-03-09 1:24 ` Ming Lei
2018-03-09 7:00 ` Artem Bityutskiy
2018-03-09 7:33 ` Ming Lei
2018-03-09 10:08 ` Thomas Gleixner
2018-03-09 12:08 ` Ming Lei
2018-03-09 15:08 ` Thomas Gleixner
2018-03-13 3:11 ` Dou Liyang
2018-03-13 7:38 ` Artem Bityutskiy
2018-03-13 8:35 ` Ming Lei [this message]
2018-03-13 8:39 ` Artem Bityutskiy
2018-03-13 9:35 ` Rafael J. Wysocki
2018-03-14 3:29 ` Dou Liyang
2018-03-14 4:11 ` Dou Liyang
2018-03-14 9:07 ` Artem Bityutskiy
2018-03-14 9:47 ` Dou Liyang
2018-03-13 9:25 ` Rafael J. Wysocki
2018-03-14 3:30 ` Dou Liyang
2018-03-30 3:15 ` Ming Lei
2018-04-03 12:55 ` Thomas Gleixner
2018-03-26 8:39 ` Thorsten Leemhuis
2018-03-28 6:15 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313083535.GA21612@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dedekind1@gmail.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox