From: Ajay Singh <ajay.kathat@microchip.com>
To: <hariprasath.elango@gmail.com>, <linux-kernel@vger.kernel.org>
Cc: devel@driverdev.osuosl.org, vbabu3@visteon.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org,
Ganesh Krishna <ganesh.krishna@microchip.com>,
aditya.shankar@microchip.com
Subject: Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
Date: Tue, 13 Mar 2018 13:00:51 +0530 [thread overview]
Message-ID: <20180313130051.43b087dd@ajaysk-VirtualBox> (raw)
In-Reply-To: <20180312093903.9147-1-hariprasath.elango@gmail.com>
Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
On Mon, 12 Mar 2018 15:09:03 +0530
<hariprasath.elango@gmail.com> wrote:
> From: HariPrasath Elango <hariprasath.elango@gmail.com>
>
Please avoid use of 'From' tag specially when there is only one
'Signed-off-by' tag and its same.
> Use the kernel pre-defined macro is_broadcast_ether_addr() instead of
> doing a memcmp here.
>
> Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com>
> ---
Regards,
Ajay
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-13 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 9:39 [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr hariprasath.elango
2018-03-13 7:30 ` Ajay Singh [this message]
2018-03-13 9:58 ` Greg Kroah-Hartman
2018-03-13 11:05 ` Ajay Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313130051.43b087dd@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasath.elango@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vbabu3@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox