From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3161771-1520946405-2-8652249256641655599 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.249, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520946402; b=wgQ1Sm/F2Yxv1jYsCt7Bw/HHtTjEWwqEFt1VEh9B0lDpnkm Rw/b9M/yg5QLgrCRbPYGuSluTicxO6SYXqJXI8WiB5X4rJTiaXJVw9TqA6UmMD7F U30S3UevPsp3hU4HIwzqvdXGEW20379LdvwYP6fx2lHIFz3rLRraGgmm7//P9Bkt MMWXaWwGFjgJvNTopctFj5sXwICEQg5j9Qx3rK9RgS08gpcq7GYGvGkUm4xarV6B SlBUrad9qltWMYOGYgD2AvI4/y6NdZ+e9WfQSrzW6Z5E2MB6XMLSq5LFgxxby/O0 CErGM4e1M/DI8p6d6JYKt0opfB22PQYyd0tGQzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1520946402; bh=k c5nVzxOxl9DM8Wlb/hzY4AMWW59b14TIdmfWLdmgvg=; b=a26hg84xBkCRHQEKF kcwMY6bjM8meovR5qPelE5pP5s/dS5gUEnXflSxGYstfFeXVlHmzgFeIkMWRF8IX 1hBv5XTu2JlLwAGlzRkirWADSmkmyNw+5mjhLhXi1WsX+/QTHSM4UICKHz6Nso/z M98QOv9QutLccQ3esHuLEezcE+IkZvT4e71xfIrxCs5+rbRHEIQ9Y1LXC+PpBBoK ewUJ713VDUVrV6lmR0JpXntma+o8xMadM5alo29bjz1cp9KUU23v+mt097wafsGS IZvq1C65jEoEZgLV14mFpQ/vzHYfGnAqgMhlLrII4jNsPoHdthEcmcj9VGdDunKE rCxwA== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=l1gD2t6Q x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=fcH1I+Oc; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=l1gD2t6Q x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=fcH1I+Oc; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Google-Smtp-Source: AG47ELvqitMhcC8qp5C7hk86+hcurZjWdmN66U4ieSXrn5bM3qNy0jUeD1uJ599q3vIYL7lamqf/PA== Date: Tue, 13 Mar 2018 10:06:29 -0300 From: Rodrigo Siqueira To: Dan Carpenter Subject: Re: [PATCH 3/3] staging:iio:ad2s1210: Add write_raw to handle frequency Message-ID: <20180313130629.c6zmvoy5o7a5ax2c@smtp.gmail.com> References: <20180313090249.cdurikolfwc5qyol@mwanda> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180313090249.cdurikolfwc5qyol@mwanda> User-Agent: NeoMutt/20171215 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Graff Yang , Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Peter Meerwald-Stadler , Hartmut Knaack , daniel.baluta@nxp.com, Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 03/13, Dan Carpenter wrote: > On Mon, Mar 12, 2018 at 03:21:52PM -0300, Rodrigo Siqueira wrote: > > The write interface of AD2S1210 utilizes IIO_DEVICE_ATTR, which violate > > the official IIO ABI. This patch, add the write_raw function responsible > > for handling the fclkin and fexcit channel; also it removes the use of > > IIO_DEVICE_ATTR for fclkin and fexcit. > > > > Signed-off-by: Rodrigo Siqueira > > --- > > drivers/staging/iio/resolver/ad2s1210.c | 117 +++++++++++++++----------------- > > 1 file changed, 55 insertions(+), 62 deletions(-) > > > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > > index 27a42ed10fcd..ea6ade4e563c 100644 > > --- a/drivers/staging/iio/resolver/ad2s1210.c > > +++ b/drivers/staging/iio/resolver/ad2s1210.c > > @@ -60,6 +60,8 @@ > > > > #define AD2S1210_DEF_EXCIT 10000 > > > > +#define ERROR_MESSAGE "ad2s1210: %s out of range\n" > > + > > Don't make this a define. That's horrible. It's a pointless layer of > abstraction. > > > > enum ad2s1210_mode { > > MOD_POS = 0, > > MOD_VEL, > > @@ -210,64 +212,6 @@ static inline int ad2s1210_soft_reset(struct ad2s1210_state *st) > > return ad2s1210_config_write(st, 0x0); > > } > > > > -static ssize_t ad2s1210_store_fclkin(struct device *dev, > > - struct device_attribute *attr, > > - const char *buf, > > - size_t len) > > -{ > > - struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); > > - unsigned int fclkin; > > - int ret; > > - > > - ret = kstrtouint(buf, 10, &fclkin); > > - if (ret) > > - return ret; > > - if (fclkin < AD2S1210_MIN_CLKIN || fclkin > AD2S1210_MAX_CLKIN) { > > - dev_err(dev, "ad2s1210: fclkin out of range\n"); > > - return -EINVAL; > > - } > > - > > - mutex_lock(&st->lock); > > - st->fclkin = fclkin; > > - > > - ret = ad2s1210_update_frequency_control_word(st); > > - if (ret < 0) > > - goto error_ret; > > - ret = ad2s1210_soft_reset(st); > > -error_ret: > > - mutex_unlock(&st->lock); > > - > > - return ret < 0 ? ret : len; > > -} > > - > > -static ssize_t ad2s1210_store_fexcit(struct device *dev, > > - struct device_attribute *attr, > > - const char *buf, size_t len) > > -{ > > - struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); > > - unsigned int fexcit; > > - int ret; > > - > > - ret = kstrtouint(buf, 10, &fexcit); > > - if (ret < 0) > > - return ret; > > - if (fexcit < AD2S1210_MIN_EXCIT || fexcit > AD2S1210_MAX_EXCIT) { > > - dev_err(dev, > > - "ad2s1210: excitation frequency out of range\n"); > > - return -EINVAL; > > - } > > - mutex_lock(&st->lock); > > - st->fexcit = fexcit; > > - ret = ad2s1210_update_frequency_control_word(st); > > - if (ret < 0) > > - goto error_ret; > > - ret = ad2s1210_soft_reset(st); > > -error_ret: > > - mutex_unlock(&st->lock); > > - > > - return ret < 0 ? ret : len; > > -} > > - > > static ssize_t ad2s1210_show_control(struct device *dev, > > struct device_attribute *attr, > > char *buf) > > @@ -545,8 +489,58 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, > > return ret; > > } > > > > -static IIO_DEVICE_ATTR(fclkin, 0644, NULL, ad2s1210_store_fclkin, 0); > > -static IIO_DEVICE_ATTR(fexcit, 0644, NULL, ad2s1210_store_fexcit, 0); > > +static int ad2s1210_write_raw(struct iio_dev *indio_dev, > > + struct iio_chan_spec const *chan, int val, > > + int val2, long mask) > > +{ > > + struct ad2s1210_state *st = iio_priv(indio_dev); > > + unsigned int clk = val; > > + int ret; > > + > > + switch (mask) { > > + case IIO_CHAN_INFO_FREQUENCY: > > + switch (chan->channel) { > > This is a switch statement with only one case. Make it an if statement > and chop out some indenting. > > if (mask != IIO_CHAN_INFO_FREQUENCY) > return -EINVAL; > > > + case FCLKIN: > > + if (clk < AD2S1210_MIN_CLKIN || > > + clk > AD2S1210_MAX_CLKIN) { > > + dev_err(&indio_dev->dev, ERROR_MESSAGE, Hi Dan, Just a note, I did it because I will add more things to this function. However, I agree with you, and I will follow your recommendation for keep things simple and focused on the present. > Ah... I see why you did the ERROR_MESSAGE define, to get around the 80 > character limit. Don't do that. Just go over 80 characters if you need > to. > > > > + "fclkin"); > > + ret = -EINVAL; > > + goto error_ret; > > Direct returns are better. Less chance of bugs statistically. I totally get your point here, and I will fix it. However, just for curiosity, why goto in this situation has more chance to generate bugs statically? I will send a v2 with your recommendantions. Thanks for the review and feedbacks :) > regards, > dan carpenter > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel