Re: [PATCH 4/4 v5 RESEND] selftests: add devpts selftests

Christian Brauner
2018-04-10T09:42:19Z

On Tue, Apr 10, 2018 at 07:34:36PM +1000, Michael Ellerman wrote:
> Christian Brauner <christian.brauner@ubuntu.com> writes:
> > On Tue, Apr 10, 2018 at 04:20:44PM +1000, Michael Ellerman wrote:
> >> Christian Brauner <christian.brauner@ubuntu.com> writes:
> >> > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> >> > index 7442dfb73b7f..dbda89c9d9b9 100644
> >> > --- a/tools/testing/selftests/Makefile
> >> > +++ b/tools/testing/selftests/Makefile
> >> > @@ -7,6 +7,7 @@ TARGETS += cpufreq
> >> > TARGETS += cpu-hotplug
> >> > TARGETS += efivarfs
> >> > TARGETS += exec
> >> > +TARGETS += filesystems
> >> ^ This, and ...
> >>
> >> > diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile
> >> > index 13a73bf725b5..4e6d09fb166f 100644
> >> > --- a/tools/testing/selftests/filesystems/Makefile
> >> > +++ b/tools/testing/selftests/filesystems/Makefile
> >> > @@ -1,5 +1,5 @@
> >> > # SPDX-License-Identifier: GPL-2.0
> >> > -TEST_PROGS := dnotify_test
> >> > +TEST_PROGS := dnotify_test devpts_pts
> >> ^
> >> this ...
> >>
> >> Have the unfortunate effect of running dnotify_test as part of the
> >> default selftest run.
> >>
> >> dnotify_test boils down to:
> >>
> >> while (1) {
> >> pause();
> >> printf("Got event on fd=%d\n", event_fd);
> >> }
> >>
> >>
> >> ie. an infinite loop :)
> >
> > Hi Michael,
> >
> > Ugh, didn't notice this before. Weird test.
>
> No worries. It looks like it was copied from Documentation where it was
> really just sample code, rather than a test.
>
> >> I'll send a patch to fix it.
> >
> > Excellent, you can likely route it through Greg's tty tree.
>
> I've sent it to the kselftest list as well as Greg, so whoever wants to
> merge it is fine by me.

Perfect, thanks!
Christian