public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
	Mario Limonciello <mario.limonciello@dell.com>,
	platform-driver-x86@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5
Date: Tue, 13 Mar 2018 20:34:45 -0700	[thread overview]
Message-ID: <20180314033445.GA10337@localhost.localdomain> (raw)
In-Reply-To: <20180312233311.GA3848@localhost.localdomain>

On Mon, Mar 12, 2018 at 04:33:11PM -0700, Darren Hart wrote:
> On Mon, Mar 12, 2018 at 03:17:57PM -0700, Linus Torvalds wrote:
> > On Mon, Mar 12, 2018 at 3:07 PM, Dominik Brodowski
> > <linux@dominikbrodowski.net> wrote:
> > >
> > > I'm awfully sorry, but this patch doesn't solve the issue.
> > > CONFIG_ACPI_WMI=y was/is set, but still enabling CONFIG_DELL_SMBIOS_WMI=y
> > > causes a very-early crash of v4.16-rc5. In fact, so early that the normal
> > > boot messages never show up on the screen...
> > 
> > Hmm. My xps13 works fine, but it's the 9350 version so not the same machine.
> > 
> > But it does sound like that commit 25d47027e10 ("platform/x86:
> > dell-smbios: Link all dell-smbios-* modules together") should just be
> > reverted. It has clearly caused a lot more pain than it fixed.
> 
> Unfortunately, yes. This will re-instate the race condition it "fixed".
> I'll work with Mario to fix this properly in 4.17, preferably in a way
> that we can apply to stable. Pending an "oops, nevermind, the patch
> works" from Dominik by tomorrow morning, I'll submit the pull request to
> revert dell-smbios changes back to and including 25d47027e10.
> 
> Apologies for the noise on this one Linus, it got away from me.

Hi Linus,

OK, I think we've identified the ordering issues and I have a patch out
pending testing from Dominik (hopefully tonight). I'd like to hold off
one more day on reverting if you're OK with that.

At RC5, we're certainly further into the RC cycle than I want to see
these changes. So if you just want to call it now, I understand and I'll
send you the revert pull request. If you can give me another day, I
think we may finally have found the end of this loose string.

Thanks,

-- 
Darren Hart
VMware Open Source Technology Center

  reply	other threads:[~2018-03-14  3:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 18:53 Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5 Dominik Brodowski
2018-03-12 20:23 ` Darren Hart
2018-03-12 22:07   ` Dominik Brodowski
2018-03-12 22:17     ` Linus Torvalds
2018-03-12 23:33       ` Darren Hart
2018-03-14  3:34         ` Darren Hart [this message]
2018-03-14 17:23           ` Linus Torvalds
2018-03-14 18:27             ` Darren Hart
2018-03-12 22:42 ` Mario.Limonciello
2018-03-13  5:51   ` Dominik Brodowski
2018-03-13  6:12     ` Mario.Limonciello
2018-03-13  6:43       ` Dominik Brodowski
2018-03-13  7:07         ` Mario.Limonciello
2018-03-13 21:42           ` Darren Hart
2018-03-14  1:28             ` Mario.Limonciello
2018-03-14  6:25               ` Dominik Brodowski
2018-03-13  6:32     ` Darren Hart
  -- strict thread matches above, loose matches on Subject: below --
2018-03-12 20:36 [PATCH v2] platform/x86: dell-smbios: Resolve dependency error on ACPI_WMI Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314033445.GA10337@localhost.localdomain \
    --to=dvhart@infradead.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=mario.limonciello@dell.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox