From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbeCNFJ7 (ORCPT ); Wed, 14 Mar 2018 01:09:59 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35415 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbeCNFJ5 (ORCPT ); Wed, 14 Mar 2018 01:09:57 -0400 X-Google-Smtp-Source: AG47ELuHZaDlF2vbnpgSArpKn5yuPjwue7ycAalplv4btywyQhodJk5V4r62Elo/SrNmLIghv9Yn3g== Date: Wed, 14 Mar 2018 10:39:54 +0530 From: Viresh Kumar To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] cpufreq: scpi: add thermal dependency Message-ID: <20180314050954.GE15832@vireshk-i7> References: <20180313114607.2061209-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180313114607.2061209-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-03-18, 12:45, Arnd Bergmann wrote: > A built-in scpi cpufreq driver cannot link against a modular > thermal framework: > > drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_ready': > scpi-cpufreq.c:(.text+0x4c): undefined reference to `of_cpufreq_cooling_register' > drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_exit': > scpi-cpufreq.c:(.text+0x9c): undefined reference to `cpufreq_cooling_unregister' > > This adds a Kconfig dependency that makes sure this configuration > is not possible, while allowing all configurations that can work. > Note that disabling CPU_THERMAL means we don't care about the > THERMAL dependency. > > Signed-off-by: Arnd Bergmann > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 9bbb5b39d18a..d9457d1e535c 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -45,6 +45,7 @@ config ARM_DT_BL_CPUFREQ > config ARM_SCPI_CPUFREQ > tristate "SCPI based CPUfreq driver" > depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI > + depends on !CPU_THERMAL || THERMAL > help > This adds the CPUfreq driver support for ARM platforms using SCPI > protocol for CPU power management. Acked-by: Viresh Kumar -- viresh