From: Greg KH <gregkh@linuxfoundation.org>
To: l4stpr0gr4m@gmail.com
Cc: devel@driverdev.osuosl.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, justin@jvreeland.com,
davem@davemloft.net, hdegoede@redhat.com,
himanshujha199640@gmail.com, hadess@hadess.net, joe@perches.com,
colin.king@canonical.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] Update rf_type_definition
Date: Wed, 14 Mar 2018 12:43:04 +0100 [thread overview]
Message-ID: <20180314114304.GC7169@kroah.com> (raw)
In-Reply-To: <1517952214-3434-1-git-send-email-l4stpr0gr4m@gmail.com>
On Wed, Feb 07, 2018 at 06:23:34AM +0900, l4stpr0gr4m@gmail.com wrote:
> From: Kangmin Park <l4stpr0gr4m@gmail.com>
Your subject line should say the subsystem and driver you are modifying.
Look at the hundreds of other patches on the mailing lists for examples
of how to properly format it.
>
> enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h
> is different from enum tag_HAL_RF_Type_Definition on
> rtl8723bs/include/HalVerDef.h
>
> So, update them to be the same reference from
> enum rf_type on rtlwifi/wifi.h which recent version.
>
> As a result, ODM_RF_TYPE_E needs to be updated as well
> Therefore, it is updated reference from enum odm_rf_type
> on rtlwifi/phydm/phydm_pre_define.h too.
> And update some additional code to check more
> chip versions that resulted from it.
>
> Also, fixed some space required errors and
> line over 80 characters warnings by checkpatch.pl.
When you say "also", that means you should be splitting this patch up
into multpile patches. Please only do one-thing-per-patch.
This should be a patch series, please fix it up and resend.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-03-14 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 21:23 [PATCH] Update rf_type_definition l4stpr0gr4m
2018-02-07 11:09 ` Dan Carpenter
2018-02-07 11:26 ` Kangmin Park
2018-03-14 11:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314114304.GC7169@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=himanshujha199640@gmail.com \
--cc=joe@perches.com \
--cc=justin@jvreeland.com \
--cc=l4stpr0gr4m@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox