linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Desnes A. Nunes do Rosario" <desnesn@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Cc: bhelgaas@google.com, benh@kernel.crashing.org, paulus@samba.org,
	mpe@ellerman.id.au, ruscur@russell.cc, aik@ozlabs.ru,
	david@gibson.dropbear.id.au, fbarrat@linux.vnet.ibm.com,
	brking@linux.vnet.ibm.com
Subject: [PATCH 0/2] Silent PCI realignment messages during boot
Date: Wed, 14 Mar 2018 13:34:53 -0300	[thread overview]
Message-ID: <20180314163455.15854-1-desnesn@linux.vnet.ibm.com> (raw)

This patchset introduces PCI_DEV_FLAGS_QUIET_PCI_REALIGN attribute in
pci_dev_flags which informs the pci subsystem to suppress all realignment
messages.

Powerpc has aligned all of its PCI resources to its PAGE_SIZE, and this
feature can be easily used on any other arch through the __weak
pcibios_default_alignment() interface.

However, since all PCI resources will be now realigned during boot, the
following messages will not only flood the system logs, but can be inter-
preted as a false positive for total PCI failure on the system.

[root@system user]# dmesg | grep -i disabling
[    0.692270] pci 0000:00:00.0: Disabling memory decoding and releasing memory resources
[    0.692324] pci 0000:00:00.0: disabling bridge mem windows
[    0.729134] pci 0001:00:00.0: Disabling memory decoding and releasing memory resources
[    0.737352] pci 0001:00:00.0: disabling bridge mem windows
[    0.776295] pci 0002:00:00.0: Disabling memory decoding and releasing memory resources
[    0.784509] pci 0002:00:00.0: disabling bridge mem windows
... and goes on for all PCI devices ...

Thus, this patchset provides a way for drivers to silent these messages if
the PCI_DEV_FLAGS_QUIET_PCI_REALIGN is turned on. Moreover, it also
tweaks this flag during boot on powerpc.

Fixes: 38274637699 ("powerpc/powernv: Override pcibios_default_alignment() to force PCI devices to be page aligned")
Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com>

Desnes A. Nunes do Rosario (2):
  pci: Addition of PCI_DEV_FLAGS_QUIET_PCI_REALIGN attribute to the PCI
    subsystem
  powerpc/powernv: Tweak PCI_DEV_FLAGS_QUIET_PCI_REALIGN on/off during
    boot

 arch/powerpc/platforms/powernv/pci.c | 14 ++++++++++++++
 drivers/pci/pci.c                    |  3 ++-
 drivers/pci/setup-res.c              |  3 ++-
 include/linux/pci.h                  |  2 ++
 4 files changed, 20 insertions(+), 2 deletions(-)

-- 
2.14.3

             reply	other threads:[~2018-03-14 16:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 16:34 Desnes A. Nunes do Rosario [this message]
2018-03-14 16:34 ` [PATCH 1/2, pci] pci: Addition of PCI_DEV_FLAGS_QUIET_PCI_REALIGN attribute to the PCI subsystem Desnes A. Nunes do Rosario
2018-03-14 17:41   ` Andy Shevchenko
2018-03-14 17:42     ` Andy Shevchenko
2018-03-14 18:09     ` Desnes Augusto Nunes do Rosário
2018-03-14 18:06   ` Bjorn Helgaas
2018-03-14 18:22     ` Desnes Augusto Nunes do Rosário
2018-03-14 18:55       ` Bjorn Helgaas
2018-03-14 21:12         ` Desnes Augusto Nunes do Rosário
2018-03-14 16:34 ` [PATCH 2/2, powerpc/powernv] powerpc/powernv: Tweak PCI_DEV_FLAGS_QUIET_PCI_REALIGN on/off during boot Desnes A. Nunes do Rosario
2018-03-16  8:41   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314163455.15854-1-desnesn@linux.vnet.ibm.com \
    --to=desnesn@linux.vnet.ibm.com \
    --cc=aik@ozlabs.ru \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=ruscur@russell.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).