public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: syzbot <syzbot+9c0d616860575a73166a@syzkaller.appspotmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, acme <acme@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	syzkaller-bugs@googlegroups.com,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: WARNING in tracepoint_probe_register_prio (2)
Date: Wed, 14 Mar 2018 17:37:46 -0400	[thread overview]
Message-ID: <20180314173746.3a6ab6eb@vmware.local.home> (raw)
In-Reply-To: <539259484.8875.1520954991870.JavaMail.zimbra@efficios.com>

On Tue, 13 Mar 2018 11:29:51 -0400 (EDT)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> Here is a WARN_ON() splat in tracepoint.c, which I suspect is caused
> by perf trying to register the same probe twice to the tracepoint API.
> We got another splat on unregister too, which I will forward in a
> separate email.
> 
> Thoughts ?

Yes, it looks like it's perf not accounting for registered events
properly.

Peter?

-- Steve



> > RIP: 0010:tracepoint_add_func kernel/tracepoint.c:210 [inline]
> > RIP: 0010:tracepoint_probe_register_prio+0x397/0x9a0 kernel/tracepoint.c:282
> > RSP: 0018:ffff8801bbc87468 EFLAGS: 00010293
> > RAX: ffff8801b5a3c680 RBX: 00000000fffffff4 RCX: ffffffff81735e67
> > RDX: 0000000000000000 RSI: ffffffff86f42a00 RDI: 0000000000000286
> > RBP: ffff8801bbc87570 R08: 1ffff10037790de1 R09: 0000000000000000
> > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
> > R13: dffffc0000000000 R14: 0000000000000000 R15: ffff8801bbc87548
> >  tracepoint_probe_register+0x2a/0x40 kernel/tracepoint.c:303
> >  trace_event_reg+0x167/0x320 kernel/trace/trace_events.c:305
> >  perf_trace_event_reg kernel/trace/trace_event_perf.c:122 [inline]
> >  perf_trace_event_init kernel/trace/trace_event_perf.c:197 [inline]
> >  perf_trace_init+0x4ef/0xab0 kernel/trace/trace_event_perf.c:221
> >  perf_tp_event_init+0x7d/0xf0 kernel/events/core.c:7979
> >  perf_try_init_event+0xc9/0x2a0 kernel/events/core.c:9240
> >  perf_init_event kernel/events/core.c:9278 [inline]
> >  perf_event_alloc+0x1cc6/0x2b00 kernel/events/core.c:9542
> >  SYSC_perf_event_open+0x84e/0x2e00 kernel/events/core.c:9997
> >  SyS_perf_event_open+0x39/0x50 kernel/events/core.c:9883
> >  do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287
> >  entry_SYSCALL_64_after_hwframe+0x42/0xb7
>

  reply	other threads:[~2018-03-14 21:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13  1:59 WARNING in tracepoint_probe_register_prio (2) syzbot
2018-03-13 15:29 ` Mathieu Desnoyers
2018-03-14 21:37   ` Steven Rostedt [this message]
2018-03-15  8:31     ` Peter Zijlstra
2018-03-15  9:19       ` Jiri Olsa
2018-03-15 11:52         ` Mathieu Desnoyers
2018-03-15 12:26           ` Jiri Olsa
2018-03-13 16:22 ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314173746.3a6ab6eb@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=syzbot+9c0d616860575a73166a@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox