From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Thierry Escande <thierry.escande@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Loic Poulain <loic.poulain@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Linux Bluetooth mailing list <linux-bluetooth@vger.kernel.org>,
linux-arm-msm@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth
Date: Wed, 14 Mar 2018 11:30:43 -0700 [thread overview]
Message-ID: <20180314183043.GX18510@minitux> (raw)
In-Reply-To: <FF2E3FDE-76C5-477A-A904-32AC064297DA@holtmann.org>
On Wed 14 Mar 09:13 PDT 2018, Marcel Holtmann wrote:
> > + bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
>
> can we use a common name here. I think that Nokia and Broadcom drivers
> define one. And if this is the enable/shutdown GPIO, we should name it
> consistently across all manufacturers. It essentially does the same on
> Bluetooth UART chips no matter what chip is behind them.
>
Broadcomm has a device-wakup-gpios and Nokia has bluetooth-wakup-gpios.
It might be that these behave in the same way, but from the description
they only trigger the wakeup.
The reason for the proposed naming here is that the pin is named
"BT_DISABLE_N" in the datasheet.
Regards,
Bjorn
next prev parent reply other threads:[~2018-03-14 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 15:55 [PATCH v4 0/3] Bluetooth: hci_qca: Add serdev support Thierry Escande
2018-03-14 15:55 ` [PATCH v4 1/3] arm64: dts: apq8096-db820c: enable bluetooth node Thierry Escande
2018-03-14 15:55 ` [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth Thierry Escande
2018-03-14 16:13 ` Marcel Holtmann
2018-03-14 18:30 ` Bjorn Andersson [this message]
2018-03-14 18:42 ` Marcel Holtmann
2018-03-14 19:05 ` Bjorn Andersson
2018-03-14 19:51 ` Marcel Holtmann
2018-03-15 11:07 ` Thierry Escande
2018-03-15 13:46 ` Sebastian Reichel
2018-03-15 13:54 ` Marcel Holtmann
2018-03-18 12:49 ` Rob Herring
2018-03-14 15:55 ` [PATCH v4 3/3] Bluetooth: hci_qca: Add serdev support Thierry Escande
2018-03-14 16:01 ` Andy Shevchenko
2018-03-14 20:14 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314183043.GX18510@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thierry.escande@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox