From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbeCOBBH (ORCPT ); Wed, 14 Mar 2018 21:01:07 -0400 Received: from mail.skyhub.de ([5.9.137.197]:35156 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbeCOBBF (ORCPT ); Wed, 14 Mar 2018 21:01:05 -0400 Date: Thu, 15 Mar 2018 02:00:29 +0100 From: Borislav Petkov To: "Maciej S. Szmigiero" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/9] x86/microcode/AMD: automatically compute the PATCH_MAX_SIZE macro Message-ID: <20180315010029.GD11061@pd.tnic> References: <20180314180209.GH16605@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 01:05:14AM +0100, Maciej S. Szmigiero wrote: > Unfortunately, this does not work: > > ./include/linux/kernel.h:806:41: error: braced-group within expression allowed only inside a function > > #define __max(t1, t2, max1, max2, x, y) ({ \ Ok, let's drop this line then. It is simply too much monkey business just to end up with max size of 4K which is F15H_MPB_MAX_SIZE, coincidentally. Just put a comment in verify_patch_size() stating that PATCH_MAX_SIZE needs to be adjusted when a bigger per-family patch size gets added. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.