From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] drm/tegra: plane: Fix RGB565 plane format on older Tegra's
Date: Thu, 15 Mar 2018 11:27:00 +0100 [thread overview]
Message-ID: <20180315102700.GA15393@ulmo> (raw)
In-Reply-To: <8d9c7220b1d2cf126bd2030e5d232ec06f761440.1521075485.git.digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On Thu, Mar 15, 2018 at 04:00:23AM +0300, Dmitry Osipenko wrote:
> Simplify opaque format adjustment by removing format checking. There are
> only 4 formats that require the adjustment and so this way is less error
> prone, avoiding mishandling native formats, like in this case RGB565 is
> the format that was erroneously treated as invalid.
>
> Fixes: ebae8d07435a ("drm/tegra: dc: Implement legacy blending")
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/gpu/drm/tegra/dc.c | 11 ++---------
> drivers/gpu/drm/tegra/plane.c | 21 ++++++---------------
> drivers/gpu/drm/tegra/plane.h | 2 +-
> 3 files changed, 9 insertions(+), 25 deletions(-)
I've applied a slightly different version of this which doesn't rework
as much of the surrounding code and is therefore easier to backport to
v4.16.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-15 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 1:00 [PATCH v1 1/3] drm/tegra: plane: Fix RGB565 plane format on older Tegra's Dmitry Osipenko
2018-03-15 1:00 ` [PATCH v1 2/3] drm/tegra: plane: Correct legacy blending Dmitry Osipenko
2018-03-15 10:29 ` Thierry Reding
2018-03-15 12:42 ` Dmitry Osipenko
2018-03-15 13:47 ` Dmitry Osipenko
2018-03-15 13:47 ` Dmitry Osipenko
2018-03-15 1:00 ` [PATCH v1 3/3] drm/tegra: dc: Dedicate overlay plane to cursor on older Tegra's Dmitry Osipenko
2018-03-15 10:45 ` Thierry Reding
2018-03-16 7:36 ` Daniel Vetter
2018-03-17 15:22 ` Dmitry Osipenko
2018-03-15 10:27 ` Thierry Reding [this message]
2018-03-15 12:48 ` [PATCH v1 1/3] drm/tegra: plane: Fix RGB565 plane format " Dmitry Osipenko
2018-03-15 12:58 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315102700.GA15393@ulmo \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).