Re: [RFC v2 09/83] Add Kconfig and Makefile

Andiry Xu
2018-03-11T21:32:12Z

On Sun, Mar 11, 2018 at 5:15 AM, Nikolay Borisov
<n.borisov.lkml@gmail.com> wrote:
>
>
> On 10.03.2018 20:17, Andiry Xu wrote:
>> From: Andiry Xu <jix024@cs.ucsd.edu>
>>
>> Signed-off-by: Andiry Xu <jix024@cs.ucsd.edu>
>> ---
>> fs/Kconfig | 2 ++
>> fs/Makefile | 1 +
>> fs/nova/Kconfig | 15 +++++++++++++++
>> fs/nova/Makefile | 7 +++++++
>> 4 files changed, 25 insertions(+)
>> create mode 100644 fs/nova/Kconfig
>> create mode 100644 fs/nova/Makefile
>>
>> diff --git a/fs/Kconfig b/fs/Kconfig
>> index bc821a8..5e9ff3e 100644
>> --- a/fs/Kconfig
>> +++ b/fs/Kconfig
>> @@ -58,6 +58,8 @@ config FS_DAX_PMD
>> depends on ZONE_DEVICE
>> depends on TRANSPARENT_HUGEPAGE
>>
>> +source "fs/nova/Kconfig"
>> +
>> # Selected by DAX drivers that do not expect filesystem DAX to support
>> # get_user_pages() of DAX mappings. I.e. "limited" indicates no support
>> # for fork() of processes with MAP_SHARED mappings or support for
>> diff --git a/fs/Makefile b/fs/Makefile
>> index add789e..65ea619 100644
>> --- a/fs/Makefile
>> +++ b/fs/Makefile
>> @@ -113,6 +113,7 @@ obj-$(CONFIG_OMFS_FS) += omfs/
>> obj-$(CONFIG_JFS_FS) += jfs/
>> obj-$(CONFIG_XFS_FS) += xfs/
>> obj-$(CONFIG_9P_FS) += 9p/
>> +obj-$(CONFIG_NOVA_FS) += nova/
>> obj-$(CONFIG_AFS_FS) += afs/
>> obj-$(CONFIG_NILFS2_FS) += nilfs2/
>> obj-$(CONFIG_BEFS_FS) += befs/
>> diff --git a/fs/nova/Kconfig b/fs/nova/Kconfig
>> new file mode 100644
>> index 0000000..c1c692e
>> --- /dev/null
>> +++ b/fs/nova/Kconfig
>> @@ -0,0 +1,15 @@
>> +config NOVA_FS
>> + tristate "NOVA: log-structured file system for non-volatile memories"
>> + depends on FS_DAX
>> + select CRC32
>
> What do you need crc32 for? Selecting libcrc32c is enough to do "the
> right thing"
>

I think this is the legacy of the removed NOVA-Fortis code. I will double check.

Thanks,
Andiry

>> + select LIBCRC32C
>> + help
>> + If your system has a block of fast (comparable in access speed to
>> + system memory) and non-volatile byte-addressable memory and you wish
>> + to mount a light-weight filesystem with strong consistency support
>> + over it, say Y here.
>> +
>> + To compile this as a module, choose M here: the module will be
>> + called nova.
>> +
>> + If unsure, say N.
>> diff --git a/fs/nova/Makefile b/fs/nova/Makefile
>> new file mode 100644
>> index 0000000..eb19646
>> --- /dev/null
>> +++ b/fs/nova/Makefile
>> @@ -0,0 +1,7 @@
>> +#
>> +# Makefile for the linux NOVA filesystem routines.
>> +#
>> +
>> +obj-$(CONFIG_NOVA_FS) += nova.o
>> +
>> +nova-y := bbuild.o inode.o rebuild.o super.o
>>