From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: davem@davemloft.net, kishon@ti.com, gregory.clement@bootlin.com,
andrew@lunn.ch, jason@lakedaemon.net,
sebastian.hesselbarth@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
maxime.chevallier@bootlin.com, miquel.raynal@bootlin.com,
nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com,
mw@semihalf.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 03/10] net: mvpp2: phylink support
Date: Fri, 16 Mar 2018 16:03:22 +0000 [thread overview]
Message-ID: <20180316160322.GR9418@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180316103351.16616-4-antoine.tenart@bootlin.com>
On Fri, Mar 16, 2018 at 11:33:44AM +0100, Antoine Tenart wrote:
> +static void mvpp2_phylink_validate(struct net_device *dev,
> + unsigned long *supported,
> + struct phylink_link_state *state)
> +{
> + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
> +
> + phylink_set(mask, Autoneg);
> + phylink_set_port_modes(mask);
> + phylink_set(mask, Pause);
> + phylink_set(mask, Asym_Pause);
> +
> + phylink_set(mask, 10baseT_Half);
> + phylink_set(mask, 10baseT_Full);
> + phylink_set(mask, 100baseT_Half);
> + phylink_set(mask, 100baseT_Full);
> + phylink_set(mask, 1000baseT_Full);
> + phylink_set(mask, 1000baseX_Full);
AFAICS, the driver (before these patches) does not support 1000baseX
as it always clears the MVPP2_GMAC_PORT_TYPE_MASK bit, so adding this
mode should be part of the patch adding 1000baseX support.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2018-03-16 16:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 10:33 [PATCH net-next 00/10] net: mvpp2: phylink conversion Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 01/10] net: mvpp2: align the ethtool ops definition Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation Antoine Tenart
2018-03-16 15:53 ` Russell King - ARM Linux
2018-03-19 8:52 ` Antoine Tenart
2018-03-19 11:12 ` Russell King - ARM Linux
2018-03-19 12:52 ` Antoine Tenart
2018-03-19 12:59 ` Andrew Lunn
2018-03-19 13:03 ` [EXT] " Stefan Chulski
2018-03-19 13:08 ` Andrew Lunn
2018-03-19 13:13 ` Antoine Tenart
2018-03-19 13:24 ` Andrew Lunn
2018-03-19 13:19 ` Stefan Chulski
2018-03-19 13:23 ` Andrew Lunn
2018-03-19 13:42 ` Russell King - ARM Linux
2018-03-19 13:10 ` Antoine Tenart
2018-03-19 13:18 ` Russell King - ARM Linux
2018-03-19 13:26 ` Antoine Tenart
2018-03-19 12:58 ` [EXT] " Stefan Chulski
2018-03-19 13:01 ` Yan Markman
2018-03-19 13:05 ` Russell King - ARM Linux
2018-03-16 10:33 ` [PATCH net-next 03/10] net: mvpp2: phylink support Antoine Tenart
2018-03-16 16:03 ` Russell King - ARM Linux [this message]
2018-03-19 8:45 ` Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 04/10] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart
2018-03-19 9:46 ` Kishon Vijay Abraham I
2018-03-16 10:33 ` [PATCH net-next 05/10] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart
2018-03-18 4:42 ` Baruch Siach
2018-03-19 8:44 ` Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 06/10] net: mvpp2: 1000baseX support Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 07/10] net: mvpp2: 2500baseX support Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 08/10] arm64: dts: marvell: 7040-db: set the 10G interface management to in-band Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 09/10] arm64: dts: marvell: 8040-db: set the 10G interfaces " Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 10/10] arm64: dts: marvell: mcbin: enable the fourth network interface Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316160322.GR9418@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox