From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3527515-1521362005-2-16414784528049101313 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES enda, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.136', Host='smtp3.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1521362005; b=GkdWjgDVYuqAdN9WswulugHoTO4Jn90Vzml0y6ECu0xYTcH fbl7LJvAV82nOhKDapL1MGoH/LY4mniFgIucL12HLjDB/An+S84w1v/FSrRK9Vyg vPBtzaRrcG9GKSPZM8bPDheFe2f6c9E5O1PWULGpuwrncME6/dA0I3Kv36BMtJUo McwjVlNWjA0ym9ZDEBxTj7qgpInZyURgS1VCbSHXejeNxFlWNXlZWPBsTLPIYiHF 5BriMstv8ob3soUhR10jOOQoRa5y0dWxaOgPVh6uWn5xDXSv8F0ZWcOyPEI2U80k oP4AQx1NIyFJ2rSEL8YmH3O/7UhGKdTPm0Rdilg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :in-reply-to:references:mime-version:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1521362005; bh=T 1cqFAez+YSNPAQl05zl7iGdYKFm2zhCcnFX35Sz9EQ=; b=ILNVcCTzcndLeH/D3 1WQc935257EInhY0324EtnMsAD7CuZ0bUCNCYFRcgEebSvoFfg6kOgpxLsGAPr+x is4C66szxNc5rAy4/sgcnWczPmQ0Un+m4u31zUKAzAN23V2hQ5rQerGXcE58TRsf rx+S7bBjFCuFiaoIV6hZW28eAh6PhUM4sYdUDFy6nFT7oRcaPsMKoDEmUUJjTWVr UDvgHbXPLaSbAF9hWO6WxWhwJ3IkG+8GZC8Gjw59AZl+VAONPuCNHP7n2gjhujeR jyk3HMsWeOFf3sPgipQVy24XC7FDAGnkxl/pBqAAE/f6QCz9W+WXtPB4Kgow5blA JsOGQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=kernel.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=kernel.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0820021720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 18 Mar 2018 08:33:14 +0000 From: Jonathan Cameron To: Himanshu Jha Subject: Re: [PATCH v2 6/9] Staging: iio: accel: adis16201: Use sign_extend32 function Message-ID: <20180318083314.3b444790@archlinux> In-Reply-To: <1521230786-18155-7-git-send-email-himanshujha199640@gmail.com> References: <1521230786-18155-1-git-send-email-himanshujha199640@gmail.com> <1521230786-18155-7-git-send-email-himanshujha199640@gmail.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, 21cnbao@gmail.com, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Sat, 17 Mar 2018 01:36:23 +0530 Himanshu Jha wrote: > Use sign_extned32() for 32 bit sign extending rather than hard coding. > > Signed-off-by: Himanshu Jha Great, applied. Thanks, Jonathan > --- > v2: > -no change in this patch. > > drivers/staging/iio/accel/adis16201.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c > index 97150ea..298bf90 100644 > --- a/drivers/staging/iio/accel/adis16201.c > +++ b/drivers/staging/iio/accel/adis16201.c > @@ -173,9 +173,8 @@ static int adis16201_read_raw(struct iio_dev *indio_dev, > ret = adis_read_reg_16(st, addr, &val16); > if (ret) > return ret; > - val16 &= (1 << bits) - 1; > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits); > - *val = val16; > + > + *val = sign_extend32(val16, bits - 1); > return IIO_VAL_INT; > } > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel