From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933294AbeCSNS1 (ORCPT ); Mon, 19 Mar 2018 09:18:27 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:40670 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932883AbeCSNSX (ORCPT ); Mon, 19 Mar 2018 09:18:23 -0400 Date: Mon, 19 Mar 2018 13:18:05 +0000 From: Russell King - ARM Linux To: Antoine Tenart Cc: Andrew Lunn , davem@davemloft.net, kishon@ti.com, gregory.clement@bootlin.com, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation Message-ID: <20180319131804.GD2743@n2100.armlinux.org.uk> References: <20180316103351.16616-1-antoine.tenart@bootlin.com> <20180316103351.16616-3-antoine.tenart@bootlin.com> <20180316155307.GQ9418@n2100.armlinux.org.uk> <20180319085252.GF4519@kwain> <20180319111205.GB2743@n2100.armlinux.org.uk> <20180319125227.GI4519@kwain> <20180319125953.GD19795@lunn.ch> <20180319131009.GJ4519@kwain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180319131009.GJ4519@kwain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 02:10:09PM +0100, Antoine Tenart wrote: > Hi Andrew, > > On Mon, Mar 19, 2018 at 01:59:53PM +0100, Andrew Lunn wrote: > > > > If they don't have PHYs, how are the connected to the outside world? > > On 7k/8k you have the following scheme for 10G only interfaces: > > MAC -- Comphy -- PHY -- SFP cage -- ... > > Or > > MAC -- Comphy -- SFP cage -- ... > > The comphy provides serdes lanes, and can be configured in various > modes (SGMII, 2500SGMII, 10GKR...). Right - the correct mode is dependent on the SFP module plugged into the cage. Trying to describe this by ignoring the SFP cage isn't going to work out well for end-user functionality, though is fine if you're just hacking a configuration to test (which would not be suitable for mainline kernels!) As I've recently replied to Yan, this is a configuration I haven't tested yet, and it's entirely possible that phylink may need some tweaks for it. What you have is a very similar setup to what is on Clearfog with its SFP cage, where the SFP cage is connected directly to the Armada 388. That only has to deal with 2500base-X / 1000base-X / SGMII and not 10G. What I want is to avoid hacks as much as possible here - if there is a short-coming with SFP/phylink here, we need to address that properly. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up