From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] tools: Fix str_error_r() Werror=restrict build
Date: Mon, 19 Mar 2018 23:23:19 +0900 [thread overview]
Message-ID: <20180319142319.GA561@tigerII.localdomain> (raw)
In-Reply-To: <20180319141612.GA2143@redhat.com>
On (03/19/18 11:16), Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 19, 2018 at 02:55:04PM +0900, Sergey Senozhatsky escreveu:
> > Commit c8b5f2c96d1bf6c ("tools: Introduce str_error_r()") added
> > an str_error_r() wrapper which makes gcc8 unhappy due to
> > restrict-qualified parameter aliasing violation:
> >
> > ../lib/str_error_r.c: In function ‘str_error_r’:
> > ../lib/str_error_r.c:25:3: error: passing argument 1 to restrict-qualified parameter aliases with argument 5 [-Werror=restrict]
> > snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, %p, %zd)=%d", errnum, buf, buflen, err);
> > ^~~~~~~~
> > cc1: all warnings being treated as errors
>
> I applied Josh's patch, just printing '[buf]', that is good enough, I
> think.
Sure. Do you need the whole "strerror_r(%d, %p, %zd)" in this case?
Seems that printing out just `errnum' should be good enough.
-ss
prev parent reply other threads:[~2018-03-19 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 5:55 [PATCH] tools: Fix str_error_r() Werror=restrict build Sergey Senozhatsky
2018-03-19 7:18 ` Jiri Olsa
2018-03-19 7:44 ` Sergey Senozhatsky
2018-03-19 14:16 ` Arnaldo Carvalho de Melo
2018-03-19 14:23 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319142319.GA561@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox