public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: devel@driverdev.osuosl.org, keescook@chromium.org,
	johannes.berg@intel.com, linux-kernel@vger.kernel.org,
	Linyu.Yuan@alcatel-sbell.com.cn, hdegoede@redhat.com,
	arnd@arndb.de, colin.king@canonical.com,
	arvind.yadav.cs@gmail.com, davem@davemloft.net,
	Larry.Finger@lwfinger.net
Subject: Re: [PATCH 1/5] Staging: rtl8723bs: os_dep
Date: Mon, 19 Mar 2018 16:43:44 +0100	[thread overview]
Message-ID: <20180319154344.GA30651@kroah.com> (raw)
In-Reply-To: <20180319143500.19623-1-paulmcquad@gmail.com>

On Mon, Mar 19, 2018 at 02:34:56PM +0000, Paul McQuade wrote:
> ERROR: do not initialise statics to NULL

You are going to have to do a bit more writing in the changelog than
just dumping in random output from checkpatch.pl.  I know that's where
that line came from, but no one else will.

And your subject lines also need a lot of work.

Please fix up for all of these patches and resend the whole series.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      parent reply	other threads:[~2018-03-19 15:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 14:34 [PATCH 1/5] Staging: rtl8723bs: os_dep Paul McQuade
2018-03-19 14:34 ` [PATCH 2/5] Staging: rtl8723bs: os_dep Spacing issue Paul McQuade
2018-03-19 14:34 ` [PATCH 3/5] Staging:rtl8723bs:os_dep braces not necessary Paul McQuade
2018-03-19 14:34 ` [PATCH 4/5] Staging:rtl8723bs:os_dep blank line needed Paul McQuade
2018-03-19 14:35 ` [PATCH 5/5] Staging:rtl8723bs:os_dep Fixed braces Paul McQuade
2018-03-19 15:43 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319154344.GA30651@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=Linyu.Yuan@alcatel-sbell.com.cn \
    --cc=arnd@arndb.de \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=hdegoede@redhat.com \
    --cc=johannes.berg@intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmcquad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox