From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030982AbeCST61 (ORCPT ); Mon, 19 Mar 2018 15:58:27 -0400 Received: from verein.lst.de ([213.95.11.211]:32996 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S970929AbeCST6C (ORCPT ); Mon, 19 Mar 2018 15:58:02 -0400 Date: Mon, 19 Mar 2018 20:58:01 +0100 From: Christoph Hellwig To: Jonas Rabenstein Cc: Scott Bauer , Jonathan Derrick , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v2 04/11] block: sed-opal: unify error handling of responses Message-ID: <20180319195801.GF3380@lst.de> References: <4a20f9848927d0f654491136e4821f2adab131cc.1521482295.git.jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a20f9848927d0f654491136e4821f2adab131cc.1521482295.git.jonas.rabenstein@studium.uni-erlangen.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 07:36:46PM +0100, Jonas Rabenstein wrote: > Also response_get_token had already been in place, its functionality had > been duplicated within response_get_{u64,bytestring} with the same error > handling. Unify the handling by reusing response_get_token within the > other functions. Should probably be one patch for each of the two separate changes. Except for that this looks fine to me: Reviewed-by: Christoph Hellwig