From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S971087AbeCSUB4 (ORCPT ); Mon, 19 Mar 2018 16:01:56 -0400 Received: from verein.lst.de ([213.95.11.211]:33050 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S971073AbeCSUBw (ORCPT ); Mon, 19 Mar 2018 16:01:52 -0400 Date: Mon, 19 Mar 2018 21:01:51 +0100 From: Christoph Hellwig To: Jonas Rabenstein Cc: Scott Bauer , Jonathan Derrick , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v2 11/11] block: sed-opal: check size of shadow mbr Message-ID: <20180319200151.GK3380@lst.de> References: <72e19ec70ffac23fff658c60eaae0db850150ca1.1521482296.git.jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72e19ec70ffac23fff658c60eaae0db850150ca1.1521482296.git.jonas.rabenstein@studium.uni-erlangen.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 07:36:53PM +0100, Jonas Rabenstein wrote: > Check whether the shadow mbr does fit in the provided space on the > target. Also a proper firmware should handle this case and return an > error we may prevent problems or even damage with crappy firmwares. > > Signed-off-by: Jonas Rabenstein > > diff --git a/block/sed-opal.c b/block/sed-opal.c > index 51f8034edbf7..9c73bd24c55f 100644 > --- a/block/sed-opal.c > +++ b/block/sed-opal.c > @@ -1545,6 +1545,20 @@ static int write_shadow_mbr(struct opal_dev *dev, void *data) > u64 len; > int err = 0; > > + /* do we fit in the available shadow mbr space? */ > + err = generic_get_table_info(dev, OPAL_MBR, OPAL_TABLE_ROWS); And here it gets used. So this should be merged with the previous patch.