Re: [PATCH 09/36] fs: unexport poll_schedule_timeout

Darrick J. Wong
2018-03-20T02:13:32Z

On Mon, Mar 05, 2018 at 01:27:16PM -0800, Christoph Hellwig wrote:
> No users outside of select.c.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> fs/select.c | 3 +--
> include/linux/poll.h | 2 --
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/select.c b/fs/select.c
> index b6c36254028a..686de7b3a1db 100644
> --- a/fs/select.c
> +++ b/fs/select.c
> @@ -233,7 +233,7 @@ static void __pollwait(struct file *filp, wait_queue_head_t *wait_address,
> add_wait_queue(wait_address, &entry->wait);
> }
>
> -int poll_schedule_timeout(struct poll_wqueues *pwq, int state,
> +static int poll_schedule_timeout(struct poll_wqueues *pwq, int state,
> ktime_t *expires, unsigned long slack)
> {
> int rc = -EINTR;
> @@ -258,7 +258,6 @@ int poll_schedule_timeout(struct poll_wqueues *pwq, int state,
>
> return rc;
> }
> -EXPORT_SYMBOL(poll_schedule_timeout);
>
> /**
> * poll_select_set_timeout - helper function to setup the timeout value
> diff --git a/include/linux/poll.h b/include/linux/poll.h
> index f45ebd017eaa..a3576da63377 100644
> --- a/include/linux/poll.h
> +++ b/include/linux/poll.h
> @@ -96,8 +96,6 @@ struct poll_wqueues {
>
> extern void poll_initwait(struct poll_wqueues *pwq);
> extern void poll_freewait(struct poll_wqueues *pwq);
> -extern int poll_schedule_timeout(struct poll_wqueues *pwq, int state,
> - ktime_t *expires, unsigned long slack);
> extern u64 select_estimate_accuracy(struct timespec64 *tv);
>
> #define MAX_INT64_SECONDS (((s64)(~((u64)0)>>1)/HZ)-1)
> --
> 2.14.2
>