From: Mark Brown <broonie@kernel.org>
To: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Cc: alsa-devel@alsa-project.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: uniphier: evea: add switch for changing source of line-in
Date: Tue, 20 Mar 2018 09:12:16 +0800 [thread overview]
Message-ID: <20180320011216.GN2186@sirena.org.uk> (raw)
In-Reply-To: <001101d3bf39$6e3933c0$4aab9b40$@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]
On Mon, Mar 19, 2018 at 01:19:10PM +0900, Katsuhiro Suzuki wrote:
> > I'll apply for now but this should really be a DAPM control so that we
> > can power down things connected to the disconnected line inputs when
> > recording.
> Thanks a lot for your suggestion. I tried to change the implementation to DAPM
> control as follows:
> I can see the value of ALINSW1 register at 'Line In 1 Mux',0 using
> amixer get 'Line In 1 Mux',0
> But I can't change the value.
> amixer set 'Line In 1 Mux',0 LIN2
> Simple mixer control 'Line In 1 Mux',0
> Capabilities: enum
> Items: 'LIN1' 'LIN2' 'LIN3'
> Item0: 'LIN1'
> Would you tell me what is wrong...
Ugh, I *have* run into that before but I can't remember what triggers it
and your code doesn't have any mistakes I can spot. Unfortunately I'm
at Linaro Connect this week and don't have a test system I can poke at
with me to remind myself, and I'm still travelling next week
unfortunately.
I'd add some trace to the set code path to make sure everything is being
called as expected. It's somemthing really small that's hard to make a
warning for in the code IIRC.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-20 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 12:39 [PATCH] ASoC: uniphier: evea: add switch for changing source of line-in Katsuhiro Suzuki
2018-03-14 16:26 ` Mark Brown
2018-03-19 4:19 ` Katsuhiro Suzuki
2018-03-20 1:12 ` Mark Brown [this message]
2018-03-20 2:35 ` Katsuhiro Suzuki
2018-03-14 16:39 ` Applied "ASoC: uniphier: evea: add switch for changing source of line-in" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320011216.GN2186@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=suzuki.katsuhiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox