From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbeCTJri (ORCPT ); Tue, 20 Mar 2018 05:47:38 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:38000 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbeCTJrg (ORCPT ); Tue, 20 Mar 2018 05:47:36 -0400 Date: Tue, 20 Mar 2018 09:47:44 +0000 From: Will Deacon To: Marc Zyngier Cc: Shanker Donthineni , linux-kernel , linux-arm-kernel , Catalin Marinas , kvmarm , Christoffer Dall , Vikram Sethi , Sean Campbell , Thomas Speier Subject: Re: [PATCH v2] arm64: KVM: Use SMCCC_ARCH_WORKAROUND_1 for Falkor BP hardening Message-ID: <20180320094744.GA24986@arm.com> References: <1520269603-2900-1-git-send-email-shankerd@codeaurora.org> <861sgx5wb6.wl-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 06:30:16PM +0000, Marc Zyngier wrote: > On 06/03/18 10:32, Marc Zyngier wrote: > > On Mon, 05 Mar 2018 17:06:43 +0000, > > Shanker Donthineni wrote: > >> > >> The function SMCCC_ARCH_WORKAROUND_1 was introduced as part of SMC > >> V1.1 Calling Convention to mitigate CVE-2017-5715. This patch uses > >> the standard call SMCCC_ARCH_WORKAROUND_1 for Falkor chips instead > >> of Silicon provider service ID 0xC2001700. > >> > >> Signed-off-by: Shanker Donthineni > >> --- > >> Chnages since v1: > >> - Trivial change in cpucaps.h (refresh after removing ARM64_HARDEN_BP_POST_GUEST_EXIT) > >> > >> arch/arm64/include/asm/cpucaps.h | 5 ++-- > >> arch/arm64/include/asm/kvm_asm.h | 2 -- > >> arch/arm64/kernel/bpi.S | 8 ------ > >> arch/arm64/kernel/cpu_errata.c | 55 ++++++++++++++-------------------------- > >> arch/arm64/kvm/hyp/entry.S | 12 --------- > >> arch/arm64/kvm/hyp/switch.c | 10 -------- > >> 6 files changed, 21 insertions(+), 71 deletions(-) > > > > Reviewed-by: Marc Zyngier > > > > Will/Catalin, if you want to take it via the arm64 tree, that's fine > > by me. > > Please allow me to change my mind. This is going to conflict horribly > with the VHE rework and the HYP randomization patches. > > I'll take it via the KVM tree, which will make everyone's life a lot easier. Sure; if you need it: Acked-by: Will Deacon You'll probably want to comment out the ARM64_HARDEN_BP_POST_GUEST_EXIT capability for now to avoid silly conflicts in -next. I can remove and renumber at -rc1. Will