From: Pratik Jain <pratik.jain0509@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: arnaud.patard@rtp-net.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function
Date: Tue, 20 Mar 2018 17:11:11 +0530 [thread overview]
Message-ID: <20180320114111.GA18734@archlinux> (raw)
In-Reply-To: <20180320112053.zxudtqeemedogcel@mwanda>
You got a valid point about `++i` and `i++`. But I still feel
that it is less complicated than previous one. I am explicitly
saying(in first loop) that we are skipping some values to get
to a specific index. Apart from that, we can avoid unncessary
wrapping and indentation. Logic becomes much more explicit if
broken down to two loops.
next prev parent reply other threads:[~2018-03-20 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 8:35 [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function Pratik Jain
2018-03-20 11:20 ` Dan Carpenter
2018-03-20 11:41 ` Pratik Jain [this message]
2018-03-20 11:54 ` Pratik Jain
2018-03-20 12:03 ` Dan Carpenter
2018-03-20 14:02 ` Pratik Jain
2018-03-21 9:24 ` Dan Carpenter
2018-03-21 9:50 ` Pratik Jain
2018-03-21 10:05 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2018-03-19 15:56 Pratik Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320114111.GA18734@archlinux \
--to=pratik.jain0509@gmail.com \
--cc=arnaud.patard@rtp-net.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox