From: "<Hariprasath Elango>" <hariprasath.elango@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: hariprasath.elango@gmail.com, aditya.shankar@microchip.com,
ganesh.krishna@microchip.com, dan.carpenter@oracle.com,
gehariprasath@gmail.com, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition
Date: Tue, 20 Mar 2018 17:38:42 +0530 [thread overview]
Message-ID: <20180320120842.GB4033@hariprasath> (raw)
In-Reply-To: <20180320114720.GA31253@kroah.com>
On Tue, Mar 20, 2018 at 12:47:21PM +0100, Greg KH wrote:
> On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.elango@gmail.com wrote:
> > From: HariPrasath Elango <hariprasath.elango@gmail.com>
> >
> > In this case,there is only a single switch case statement.So replacing
> > by a simple if condition
> >
> > Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com>
> > ---
> > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +-------
> > 1 file changed, 1 insertion(+), 7 deletions(-)
>
> What changed from v1? Always put that information below the --- line,
> like the kernel documentation asks you to do.
>
> v3? :)
>
> thanks,
>
> greg k-h
Lesson learned. I will send a v3 with version history included
regards,
hari prasath
prev parent reply other threads:[~2018-03-20 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 11:43 [PATCHv2] staging: wilc1000: replace switch statement by simple if condition hariprasath.elango
2018-03-20 11:47 ` Greg KH
2018-03-20 12:08 ` <Hariprasath Elango> [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320120842.GB4033@hariprasath \
--to=hariprasath.elango@gmail.com \
--cc=aditya.shankar@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gehariprasath@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox