From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Guenter Roeck <linux@roeck-us.net>, Jun Li <jun.li@nxp.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup
Date: Tue, 20 Mar 2018 14:52:40 +0200 [thread overview]
Message-ID: <20180320125240.GA25137@kuha.fi.intel.com> (raw)
In-Reply-To: <eb9950fe-54fd-eda8-e678-f2216204f62f@redhat.com>
On Tue, Mar 20, 2018 at 01:21:57PM +0100, Hans de Goede wrote:
> On 20-03-18 11:32, Heikki Krogerus wrote:
> > On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote:
> > > > > +void device_connection_remove(struct device_connection *con)
> > > > > +{
> > > > > + mutex_lock(&devcon_lock);
> > > > > + list_del_rcu(&con->list);
> > > >
> > > > See, rcu?
> > >
> > > True. I'll send one more version.
> >
> > Before I do that, Hans, can you quickly check this and see that I
> > have not made any more mistakes? I don't trust myself anymore with
> > these.
>
> This looks good to me (note I did not test only reviewed).
Thanks. I'll send v9.
Br,
--
heikki
next prev parent reply other threads:[~2018-03-20 12:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 13:12 [PATCH v8 00/12] USB Type-C device-connection, mux and switch support Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 01/12] drivers: base: Unified device connection lookup Heikki Krogerus
2018-03-20 9:20 ` Greg Kroah-Hartman
2018-03-20 10:04 ` Heikki Krogerus
2018-03-20 10:32 ` Heikki Krogerus
2018-03-20 12:21 ` Hans de Goede
2018-03-20 12:52 ` Heikki Krogerus [this message]
2018-03-14 13:12 ` [PATCH v8 02/12] usb: typec: API for controlling USB Type-C Multiplexers Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 03/12] usb: common: Small class for USB role switches Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 04/12] usb: typec: Separate the definitions for data and power roles Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 06/12] usb: typec: tcpm: Use new Type-C switch/mux and usb-role-switch functions Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 07/12] xhci: Add option to get next extended capability in list by passing id = 0 Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 08/12] xhci: Add Intel extended cap / otg phy mux handling Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 09/12] usb: roles: Add Intel xHCI USB role switch driver Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 10/12] usb: typec: driver for Pericom PI3USB30532 Type-C cross switch Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 11/12] platform/x86: intel_cht_int33fe: Add device connections for the Type-C port Heikki Krogerus
2018-03-14 13:12 ` [PATCH v8 12/12] extcon: axp288: Set USB role where necessary Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320125240.GA25137@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andy@infradead.org \
--cc=cw00.choi@samsung.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mathias.nyman@intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox