From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752675AbeCUPqE (ORCPT ); Wed, 21 Mar 2018 11:46:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:36230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbeCUPpl (ORCPT ); Wed, 21 Mar 2018 11:45:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00C94217D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 21 Mar 2018 12:45:38 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: "Jin, Yao" , jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH] perf util: Display warning when perf report/annotate is missing some libs Message-ID: <20180321154538.GE24312@kernel.org> References: <1515668586-14327-1-git-send-email-yao.jin@linux.intel.com> <20180111153028.GB20406@krava> <42a90e87-f2fd-293d-bd25-591fcdff14e1@linux.intel.com> <20180321153807.GA2707@krava> <20180321154035.GC24312@kernel.org> <20180321154315.GD24312@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180321154315.GD24312@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Mar 21, 2018 at 12:43:15PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 12:40:35PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Mar 21, 2018 at 04:38:07PM +0100, Jiri Olsa escreveu: > > > On Wed, Mar 21, 2018 at 10:11:10AM +0800, Jin, Yao wrote: > > > > Hi Jiri, > > > > > > > > I'm still thinking it's worth displaying the warning when perf missing some > > > > libraries. > > > > > > > > Somebody just told me that perf didn't work well. While after some > > > > investigations, I found it's just missing some libraries when building the > > > > perf. > > > > > > > > But I have spent some time on getting the root cause. If with this patch, it > > > > should be very easily to know that. > > > > > > true.. Arnaldo, any feedback on this one? > > > > Lemme re-read the thread... > > Well, how about we make it harder to build without key libraries? I.e. > if we detect that what we consider a core set of libraries isn't found > in the system, then we stop the build, warn about it and ask the user to > confirm that the build should proceed by passing some explicit > -DI_KNOW_WHAT_I_AM_DOING___PROCEED=doit > > ? And for some stuff, that we know people feel strongly about, like PeterZ with the TUI, the warning has to be subtle, like a one line "Please build with slang-devel to have interactive annotation". - Arnaldo