From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752911AbeCUSuN (ORCPT ); Wed, 21 Mar 2018 14:50:13 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:60696 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752760AbeCUSuK (ORCPT ); Wed, 21 Mar 2018 14:50:10 -0400 Date: Wed, 21 Mar 2018 11:50:01 -0700 From: Christoph Hellwig To: Arnaldo Carvalho de Melo Cc: Sebastian Andrzej Siewior , "Nicholas A. Bellinger" , Thomas Gleixner , LKML , linux-rt-users , Steven Rostedt , linux-scsi@vger.kernel.org, Daniel Bristot de Oliveira , Luis Claudio =?iso-8859-1?Q?R=2E_Gon=E7alves?= , Clark Williams , target-devel@vger.kernel.org Subject: Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled()) Message-ID: <20180321185001.GB11249@infradead.org> References: <20180321153854.GB24312@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180321153854.GB24312@kernel.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > assert_spin_locked(&cmd->t_state_lock); > - WARN_ON_ONCE(!irqs_disabled()); > + WARN_ON_ONCE_NONRT(!irqs_disabled()); I can't find where WARN_ON_ONCE_NONRT is defined. That being said I think we can just kill these asserts. If we have irqs disabled spin_unlock_irq a few lines below should already warn.