Re: [PATCH v7 03/14] block, dax: remove dead code in blkdev_writepages()

Jan Kara
2018-03-29T15:29:24Z

On Wed 21-03-18 15:57:27, Dan Williams wrote:
> Block device inodes never have S_DAX set, so kill the check for DAX and
> diversion to dax_writeback_mapping_range().
>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Matthew Wilcox <mawilcox@microsoft.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dave Chinner <david@fromorbit.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> fs/block_dev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index fe09ef9c21f3..846ee2d31781 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -1946,11 +1946,6 @@ static int blkdev_releasepage(struct page *page, gfp_t wait)
> static int blkdev_writepages(struct address_space *mapping,
> struct writeback_control *wbc)
> {
> - if (dax_mapping(mapping)) {
> - struct block_device *bdev = I_BDEV(mapping->host);
> -
> - return dax_writeback_mapping_range(mapping, bdev, wbc);
> - }
> return generic_writepages(mapping, wbc);
> }
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR